Add feature gate tests #24749
Add feature gate tests #24749
Conversation
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
|
It looks to me like a couple of tests got renamed when they should have been copied, the end result is we lose two tests. Is that accidental or deliberate? |
|
Thanks, I was just about to comment on this. The diff on Github shows files as being renamed, however the individual commits themselves do no such thing. Not sure what happened, I'll look into this further. |
|
There is a commit that deletes some duplicate tests (1ec6bb7) and these deleted files are showing up as being renamed in the diff on Github. But locally a I am going to split out the deletions and submit them as a separate PR as having the rename in the history on Github is not the intended meaning of the changeset. Hopefully that will make the changes appear as intended on Github. |
|
Sorry there was an error in that latest push, fixing now... |
As part of the audit for #22820 the following feature gate tests have been added: * `negate_unsigned` * `on_unimplemented` * `optin_builtin_traits` * `plugin` * `rustc_attrs` * `slice_patterns`
|
Ok, sorry about mixup there, I've removed the duplicate tests that were deleted from this PR, I will submit them in a separate PR. Thanks. |
As part of the audit for rust-lang#22820 the following feature gate tests have been added: * `negate_unsigned` * `on_unimplemented` * `optin_builtin_traits` * `plugin` * `rustc_attrs` * `rustc_diagnostic_macros` * `slice_patterns` In addition some feature gate error message typos fixed.
As part of the audit for #22820 the following feature gate tests have been
added:
negate_unsignedon_unimplementedoptin_builtin_traitspluginrustc_attrsrustc_diagnostic_macrosslice_patternsIn addition some feature gate error message typos fixed.