Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several Minor API / Reference Documentation Fixes #25290

Merged
merged 5 commits into from
May 11, 2015
Merged

Conversation

bluss
Copy link
Member

@bluss bluss commented May 10, 2015

Several Minor API / Reference Documentation Fixes

  • Fix a few small errors in the reference.
  • Fix paper cuts in the API docs.

Fixes #24882
Fixes #25233
Fixes #25250

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@bluss
Copy link
Member Author

bluss commented May 10, 2015

r? @steveklabnik

thanks!!

@steveklabnik
Copy link
Member

This says it can't be merged. Can you rebase?

@bluss
Copy link
Member Author

bluss commented May 11, 2015

Rebased. Intelligently enough it conflicted with my own previous PR.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 11, 2015

📌 Commit aabdd8e has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thanks!

Manishearth added a commit to Manishearth/rust that referenced this pull request May 11, 2015
Several Minor API / Reference Documentation Fixes

- Fix a few small errors in the reference.
- Fix paper cuts in the API docs.

Fixes rust-lang#24882
Fixes rust-lang#25233
Fixes rust-lang#25250
Manishearth added a commit to Manishearth/rust that referenced this pull request May 11, 2015
Several Minor API / Reference Documentation Fixes

- Fix a few small errors in the reference.
- Fix paper cuts in the API docs.

Fixes rust-lang#24882
Fixes rust-lang#25233
Fixes rust-lang#25250
bors added a commit that referenced this pull request May 11, 2015
@bors bors merged commit aabdd8e into rust-lang:master May 11, 2015
@frewsxcv
Copy link
Member

Is it too late to get this backported?

@steveklabnik
Copy link
Member

@frewsxcv i am backporting the entire book, reference, and grammar right before the release.

@frewsxcv
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants