rustc: implement unstable(issue = "nnn").
#26747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
|
cc @rust-lang/libs, particularly @aturon and @alexcrichton |
| @@ -501,6 +517,11 @@ fn find_stability_generic<'a, | |||
| either stable or unstable attribute"); | |||
| } | |||
| } | |||
| } else if stab.as_ref().map_or(false, |s| s.level == Unstable && s.issue.is_none()) { | |||
| // no-deprecated unstable items need to point to issues. | |||
|
r=me for the actual code with nits addressed Actual feature itself seems legit (I vaguely recall overhearing this discussed as desirable earlier today) |
|
No opinion here. |
This takes an issue number and points people to it in the printed error message. This commit does not make it an error to have no `issue` field.
bors
added a commit
that referenced
this pull request
Jul 7, 2015
This takes an issue number and points people to it in the printed error message. This commit does not make it an error to have no `issue` field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes an issue number and points people to it in the printed error
message. This commit does not make it an error to have no
issuefield.