Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove #[derive(Show)] #29148

Merged
merged 1 commit into from
Oct 20, 2015
Merged

Remove #[derive(Show)] #29148

merged 1 commit into from
Oct 20, 2015

Conversation

petrochenkov
Copy link
Contributor

Closes #29145

[breaking-change], needs a crater run.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

Starting a crater run

@alexcrichton
Copy link
Member

Crater reports one regression currently. At least good to know that it's not widespread!

Given the low amount of breakage and the fact that warnings have been in place for quite some time I'm going to r+, thanks @petrochenkov!

@bors: r+ 025cf75

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 19, 2015
@bors
Copy link
Contributor

bors commented Oct 20, 2015

⌛ Testing commit 025cf75 with merge 93ab95e...

@bors
Copy link
Contributor

bors commented Oct 20, 2015

💔 Test failed - auto-linux-64-nopt-t

@petrochenkov
Copy link
Contributor Author

The failure looks spurious.

oli-obk added a commit to oli-obk/rust-ids-container that referenced this pull request Oct 20, 2015
`derive(Show)` has been deprecated for a while. This is the only regression detected by crater. See also [the pull request that will break this crate](rust-lang/rust#29148 (comment))
@alexcrichton
Copy link
Member

@bors: retry

On Tue, Oct 20, 2015 at 4:12 AM, Vadim Petrochenkov <
notifications@github.com> wrote:

The failure looks spurious.


Reply to this email directly or view it on GitHub
#29148 (comment).

@bors
Copy link
Contributor

bors commented Oct 20, 2015

⌛ Testing commit 025cf75 with merge 5f90a0a...

@alexcrichton
Copy link
Member

@bors: retry force

@bors
Copy link
Contributor

bors commented Oct 20, 2015

⌛ Testing commit 025cf75 with merge 97ba52e...

bors added a commit that referenced this pull request Oct 20, 2015
Closes #29145

[breaking-change], needs a crater run.
@bors bors merged commit 025cf75 into rust-lang:master Oct 20, 2015
@petrochenkov petrochenkov deleted the noshow branch November 22, 2015 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants