Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement negation for wrapping numerals. #33067

Merged
merged 1 commit into from
May 5, 2016

Conversation

notriddle
Copy link
Contributor

@notriddle notriddle commented Apr 18, 2016

Fixes #33037

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jonas-schievink
Copy link
Contributor

Impls are insta-stable, stability attributes have no effect on them

@alexcrichton
Copy link
Member

Thanks for the PR @notriddle! As @jonas-schievink mentioned we unfortunately don't read stability annotations on impl blocks, so this'll be instantly stable regardless so we may as well tag it with #[stable] with a since of 0.10.0

I'll tag this with T-libs as well to be sure it comes up during triage.

@alexcrichton alexcrichton added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Apr 18, 2016
@notriddle notriddle force-pushed the wrapping_neg branch 3 times, most recently from af4efb1 to 9cb4d1b Compare April 18, 2016 20:24
@brson brson added the relnotes Marks issues that should be documented in the release notes of the next release. label May 4, 2016
@alexcrichton
Copy link
Member

The libs team discussed this during triage today and the decision was to merge. Thanks again for the PR @notriddle!

@bors: r+ 8a8c432

@bors
Copy link
Contributor

bors commented May 5, 2016

⌛ Testing commit 8a8c432 with merge 3f65afa...

bors added a commit that referenced this pull request May 5, 2016
Implement negation for wrapping numerals.

Fixes #33037
@bors
Copy link
Contributor

bors commented May 5, 2016

💔 Test failed - auto-win-msvc-64-cargotest

@arielb1
Copy link
Contributor

arielb1 commented May 5, 2016

---- test_cargo_freshness::rebuild_tests_if_lib_changes stdout ----
    thread 'test_cargo_freshness::rebuild_tests_if_lib_changes' panicked at 'called `Result::unwrap()` on an `Err` value: Error { repr: Os { code: 32, message: "The process cannot access the file because it is being used by another process." } }', C:\bot\slave\auto-win-msvc-64-cargotest\build\src\libcore\result.rs:785
note: Run with `RUST_BACKTRACE=1` for a backtrace.


failures:
    test_cargo_freshness::rebuild_tests_if_lib_changes

cc @alexcrichton

can has RUST_BACKTRACE plz?

@bors retry

@bors bors merged commit 8a8c432 into rust-lang:master May 5, 2016
@alexcrichton
Copy link
Member

@arielb1

I've opened up rust-lang/cargo#2650, and I've seen this issue quite a few times on Cargo itself unfortunately.

I haven't been able to reproduce locally yet, though, to debug.

@notriddle notriddle deleted the wrapping_neg branch May 5, 2016 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants