Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

book: fix formatting of module layout example #35466

Merged
merged 1 commit into from
Aug 10, 2016
Merged

book: fix formatting of module layout example #35466

merged 1 commit into from
Aug 10, 2016

Conversation

xitep
Copy link

@xitep xitep commented Aug 7, 2016

No description provided.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@xitep
Copy link
Author

xitep commented Aug 7, 2016

Just noticed that the "creates and module" layout graph is broken for nightlies; hopefully this fixes the issue.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Aug 7, 2016

📌 Commit 98c6770 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 7, 2016
Rollup merge of rust-lang#35466 - xitep:master, r=steveklabnik
3fdd637 
book: fix formatting of module layout example
@sophiajt sophiajt mentioned this pull request Aug 7, 2016
Closed
bors added a commit that referenced this pull request Aug 7, 2016
@bors
Auto merge of #35476 - jonathandturner:rollup, r=jonathandturner
8913330 
Rollup of 6 pull requests

- Successful merges: #35396, #35402, #35446, #35466, #35470, #35475
- Failed merges: #35395, #35415
@bors
Copy link
Contributor

bors commented Aug 8, 2016

⌛ Testing commit 98c6770 with merge 42f92b8...

@bors
Copy link
Contributor

bors commented Aug 8, 2016

💔 Test failed - auto-win-gnu-64-opt

@steveklabnik
Copy link
Member

@bors: retry

seems spurious

@alexcrichton
Copy link
Member

@bors: retry

  • not sure why...

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 8, 2016
Rollup merge of rust-lang#35466 - xitep:master, r=steveklabnik
3d2d5c4 
book: fix formatting of module layout example
@sophiajt sophiajt mentioned this pull request Aug 8, 2016
Merged
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge of rust-lang#35466 - xitep:master, r=steveklabnik
7377583 
book: fix formatting of module layout example
@steveklabnik steveklabnik mentioned this pull request Aug 10, 2016
Closed
bors added a commit that referenced this pull request Aug 10, 2016
@bors
Auto merge of #35525 - jonathandturner:rollup, r=jonathandturner
1f2ae38 
Rollup of 15 pull requests

- Successful merges: #35371, #35396, #35446, #35449, #35452, #35458, #35465, #35466, #35470, #35475, #35477, #35484, #35504, #35507, #35524
- Failed merges: #35395, #35415
@bors bors merged commit 98c6770 into rust-lang:master Aug 10, 2016
@durka durka mentioned this pull request Aug 23, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Manishearth Manishearth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xitep @rust-highfive @steveklabnik @bors @alexcrichton @Manishearth