Refactor PathListItems
#35618
Merged
Refactor PathListItems
#35618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Manishearth -- I'm not sure if this will cause breakage for plugins in practice. |
|
It will. |
| pub struct PathListItem_ { | ||
| pub name: Ident, | ||
| /// renamed in list, e.g. `use foo::{bar as baz};` | ||
| pub rename: Option<Ident>, |
There was a problem hiding this comment.
name and rename can be Names (cc #28659)
(Unless we are trying to future proof for some kind of item hygiene.)
There was a problem hiding this comment.
Unless we are trying to future proof for some kind of item hygiene.
We are :)
|
LGTM, modulo more tests. |
jseyfried
force-pushed
the
ast_view_path_refactor
branch
from
40ef089
to
b725da1
Compare
|
This PR no longer changes diagnostics (c.f. this comment). |
|
☔ The latest upstream changes (presumably #35776) made this pull request unmergeable. Please resolve the merge conflicts. |
and refactor `ast::PathListItemKind::Ident` -> `ast::PathListItem_`.
and refacotor `hir::PathListItem_::Ident` -> `hir::PathListItem_`.
jseyfried
force-pushed
the
ast_view_path_refactor
branch
from
b725da1
to
9d99fe9
Compare
jseyfried
added a commit
to jseyfried/rust
that referenced
this pull request
Aug 28, 2016
…=eddyb Refactor `PathListItem`s This refactors away variant `Mod` of `ast::PathListItemKind` and refactors the remaining variant `Ident` to a struct `ast::PathListItem_`.
bors
added a commit
that referenced
this pull request
Aug 30, 2016
Batch up libsyntax breaking changes Batch of the following syntax-[breaking-change] changes: - #35591: Add a field `span: Span` to `ast::Generics`. - #35618: Remove variant `Mod` of `ast::PathListItemKind` and refactor the remaining variant `ast::PathListKind::Ident` to a struct `ast::PathListKind_`. - #35480: Change uses of `Constness` in the AST to `Spanned<Constness>`. - c.f. `MethodSig`, `ItemKind` - #35728: Refactor `cx.pat_enum()` into `cx.pat_tuple_struct()` and `cx.pat_path()`. - #35850: Generalize the elements of lists in attributes from `MetaItem` to a new type `NestedMetaItem` that can represent a `MetaItem` or a literal. - #35917: Remove traits `AttrMetaMethods`, `AttributeMethods`, and `AttrNestedMetaItemMethods`. - Besides removing imports of these traits, this won't cause fallout. - Add a variant `Union` to `ItemKind` to future proof for `union` (c.f. #36016). - Remove inherent methods `attrs` and `fold_attrs` of `Annotatable`. - Use methods `attrs` and `map_attrs` of `HasAttrs` instead. r? @Manishearth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syntax-[breaking-change] cc #31645
This refactors away variant
Modofast::PathListItemKindand refactors the remaining variantIdentto a structast::PathListItem_.r? @eddyb