Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace unnecessary uses of TraitObject with casts #36005

Merged
merged 1 commit into from
Aug 27, 2016
Merged

Replace unnecessary uses of TraitObject with casts #36005

merged 1 commit into from
Aug 27, 2016

Conversation

apasel422
Copy link
Contributor

@eddyb
Copy link
Member

eddyb commented Aug 26, 2016

LGTM, nice catch!

@alexcrichton
Copy link
Member

@bors: r+ 47a7cdc85243cad70aa024e6270cc3c83b6b66f2

Nice!

@bors
Copy link
Contributor

bors commented Aug 26, 2016

☔ The latest upstream changes (presumably #35906) made this pull request unmergeable. Please resolve the merge conflicts.

@apasel422
Copy link
Contributor Author

Rebased.

@eddyb
Copy link
Member

eddyb commented Aug 26, 2016

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Aug 26, 2016

📌 Commit 2b10df7 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Aug 26, 2016

⌛ Testing commit 2b10df7 with merge a5d320c...

@bors
Copy link
Contributor

bors commented Aug 26, 2016

💔 Test failed - auto-win-msvc-64-opt-rustbuild

@apasel422
Copy link
Contributor Author

@bors: retry

@Manishearth Manishearth mentioned this pull request Aug 27, 2016
Merged
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
@Manishearth
Rollup merge of rust-lang#36005 - apasel422:traitobj, r=alexcrichton
30835ec 
Replace unnecessary uses of `TraitObject` with casts

r? @alexcrichton
bors added a commit that referenced this pull request Aug 27, 2016
@bors
Auto merge of #36030 - Manishearth:rollup, r=Manishearth
099b9fd 
Rollup of 7 pull requests

- Successful merges: #35124, #35877, #35953, #36002, #36004, #36005, #36014
- Failed merges:
@bors bors merged commit 2b10df7 into rust-lang:master Aug 27, 2016
@apasel422 apasel422 deleted the traitobj branch August 27, 2016 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@apasel422 @eddyb @alexcrichton @bors