Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configure script to accept LLVM version 4 #37639

Closed
wants to merge 1 commit into from

Conversation

tigerleapgorge
Copy link

LLVM has moved to version 4.0.0,
Configure script still expect LLVM version 3.7 to 3.9.
With this small change "--llvm-root" can work with latest upstream LLVM.

Useful when invoking configure with --llvm-root point to lastest LLVM.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@nagisa
Copy link
Member

nagisa commented Nov 7, 2016

Supporting LLVM 4.0 is more involved than just changing a switch. See #37609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants