Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Update the OSX image we run tests in #38507

Merged
merged 1 commit into from
Dec 27, 2016

Conversation

alexcrichton
Copy link
Member

The current image is xcode7.3, Travis's current default. Unfortunately this
has a version of LLDB which doesn't support debuginfo-lldb tests (see #32520),
so we're not running LLDB tests on Travis yet.

This switches us to the newest image from Travis, xcode8.2, which should have
a newer version of LLDB we can run tests against.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member Author

Note that I'd like to see this work on travis before merging, I don't plan to merge with the addition of ALLOW_PR=1

@alexcrichton
Copy link
Member Author

Ok so unfortunately that didn't work for what I believe is the reason that if you configure sccache to use an S3 bucket it doesn't work if the configuration is wrong. PRs don't have access to the secret key, so I think sccache chokes.

I'm reasonably confident that this will succeed, though, because the listed LLDB version is 360, not 350.

r? @brson

@brson
Copy link
Contributor

brson commented Dec 24, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2016

📌 Commit e5fcb11 has been approved by brson

@bors
Copy link
Contributor

bors commented Dec 26, 2016

⌛ Testing commit e5fcb11 with merge 41bbca1...

@bors
Copy link
Contributor

bors commented Dec 26, 2016

💔 Test failed - status-travis

The current image is `xcode7.3`, Travis's current default. Unfortunately this
has a version of LLDB which doesn't support debuginfo-lldb tests (see rust-lang#32520),
so we're not running LLDB tests on Travis yet.

This switches us to the newest image from Travis, `xcode8.2`, which should have
a newer version of LLDB we can run tests against.
@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Contributor

bors commented Dec 26, 2016

📌 Commit dad0076 has been approved by alexcrichton

@alexcrichton
Copy link
Member Author

@bors: r=brson

@bors
Copy link
Contributor

bors commented Dec 26, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 26, 2016

📌 Commit dad0076 has been approved by brson

@bors
Copy link
Contributor

bors commented Dec 27, 2016

⌛ Testing commit dad0076 with merge c2ee32a...

bors added a commit that referenced this pull request Dec 27, 2016
travis: Update the OSX image we run tests in

The current image is `xcode7.3`, Travis's current default. Unfortunately this
has a version of LLDB which doesn't support debuginfo-lldb tests (see #32520),
so we're not running LLDB tests on Travis yet.

This switches us to the newest image from Travis, `xcode8.2`, which should have
a newer version of LLDB we can run tests against.
@bors
Copy link
Contributor

bors commented Dec 27, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: brson
Pushing c2ee32a to master...

@bors bors merged commit dad0076 into rust-lang:master Dec 27, 2016
@alexcrichton alexcrichton deleted the travis-lldb branch December 30, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants