Rollup of 5 pull requests #39686
Rollup of 5 pull requests #39686
Conversation
…utes. This effectively deprecates lookup_repr_hints.
* Move to a separate float mod * Add more tests for f64 f32 lower exp upper exp * Use assert_eq for a clearer error message
Make reprs use a structured representation instead of a slice This is needed for `-z reorder-fields`. The old design uses a slice taken from HIR, plus a cache that lazily parses. The new design stores it directly in the `AdtDef` as a `ReprOptions`. We're doing this now because we need to be able to add reprs that don't necessarily exist in HIR for `-z reorder-fields`, but it needs to happen anyway. `lookup_repr_hints` should be mostly deprecated. I want to remove it from `layout` before closing this, unless people think that should be a separate PR. The `[WIP]` is because of this. The problem with closing this as-is is that the code here isn't actually testable until some parts of the compiler start using it. r? @eddyb
…aarch64-unknown-freebsd, r=alexcrichton liblibc: Update to include `aarch64-unknown-freebsd` support
Fix ICE when accessing mutably an immutable enum Fix rust-lang#39544.
Improve format float * Move float into mod float like in test * Add more tests for f64 f32, lower exp, upper exp, which can come if handy in the future if we want refactor further * Use `assert_eq` for clearer error messages
build std for sparc64-unknown-linux-gnu r? @alexcrichton panicking / unwinding is broken (rust-lang#39646) but with std available at least people will be able to debug that issue on real hardware
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @eddyb (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@bors r+ p=10 |
|
📌 Commit 116bdac has been approved by |
|
⌛ Testing commit 116bdac with merge e7fc53b... |
|
☀️ Test successful - status-appveyor, status-travis |
aarch64-unknown-freebsdsupport #39601, Fix ICE when accessing mutably an immutable enum #39602, Improve format float #39615, build std for sparc64-unknown-linux-gnu #39647