Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding compile fail test for staged_api feature #39772

Merged
merged 1 commit into from
Feb 15, 2017

Conversation

cseale
Copy link
Contributor

@cseale cseale commented Feb 12, 2017

Issue #39059
r? @est31

@est31 running the tests for this feature fails. Is that expected since this is the compile-failsuite?

I copied this test from the run-pass suite: rust/src/test/run-pass/reachable-unnameable-type-alias.rs. What are the differences between these suites in operation and why they are used?

@est31
Copy link
Member

est31 commented Feb 13, 2017

Is that expected since this is the compile-fail suite?

No, tests in the compile-fail suite are expected to fail compilation, but it will show up to you as "success". You need to tell it about the error messages that were excepted, if it encounters errors that didn't match it fails, which probably happened here. For how to mark the errors, you should read COMPILER_TESTS.md. Also, you can have a look at how #39700 did it.

What are the differences between these suites in operation and why they are used?

Run-pass is for tests that are expected to be compiled and not panic or segfault when they run, and compile-fail is for tests that fail to compile. There are other test suites as well, like parse-fail for tests that fail much earlier in compilation, during parsing. Usually though tests are in compile-fail and not parse-fail.

@cseale cseale force-pushed the staged_api_whitelist_removal branch from e56d130 to 3a54eee Compare February 13, 2017 22:50
@cseale cseale force-pushed the staged_api_whitelist_removal branch from 3a54eee to 07b3a8b Compare February 14, 2017 00:05
@aturon
Copy link
Member

aturon commented Feb 14, 2017

@bors delegate=est32

@bors
Copy link
Contributor

bors commented Feb 14, 2017

✌️ @est32 can now approve this pull request

@aturon
Copy link
Member

aturon commented Feb 14, 2017

Helps if I get the user name right...

@bors delegate=est31

@bors
Copy link
Contributor

bors commented Feb 14, 2017

✌️ @est31 can now approve this pull request

@aturon
Copy link
Member

aturon commented Feb 14, 2017

@bors r=est31

@bors
Copy link
Contributor

bors commented Feb 14, 2017

📌 Commit 07b3a8b has been approved by est31

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 14, 2017
…, r=est31

Adding compile fail test for staged_api feature

Issue rust-lang#39059
r? @est31

@est31 running the tests for this feature fails. Is that expected since this is the `compile-fail`suite?

I copied this test from the run-pass suite: `rust/src/test/run-pass/reachable-unnameable-type-alias.rs`. What are the differences between these suites in operation and why they are used?
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Feb 14, 2017
…, r=est31

Adding compile fail test for staged_api feature

Issue rust-lang#39059
r? @est31

@est31 running the tests for this feature fails. Is that expected since this is the `compile-fail`suite?

I copied this test from the run-pass suite: `rust/src/test/run-pass/reachable-unnameable-type-alias.rs`. What are the differences between these suites in operation and why they are used?
bors added a commit that referenced this pull request Feb 14, 2017
Rollup of 8 pull requests

- Successful merges: #39659, #39730, #39754, #39772, #39785, #39788, #39790, #39813
- Failed merges:
@bors bors merged commit 07b3a8b into rust-lang:master Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants