Rollup of 5 pull requests #40160
Closed
Rollup of 5 pull requests #40160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
Feb 28, 2017
steveklabnik
commented
- Successful merges: Structs doc: Change "pointers" to "references" #40142, Unit-like structs doc: Improve code sample #40144, Add compile test for cfg_target_has_atomic #40150, update mdbook version #40151, sort unstable book alphabetically #40153
- Failed merges:
This contains two important bugfixes
I made these the same order as they were in the compiler, but for no good reason. Much easier to find out what you need when they're sorted alphabetically
Structs doc: Change "pointers" to "references" Let's call them "references" instead of "pointers". That's how they're called in chapter 4.9 "References and Borrowing". r? @steveklabnik
Unit-like structs doc: Improve code sample r? @steveklabnik BTW it seems that ```Rust let p = Proton {}; ``` compiles without an error. That's why I didn't add it to the example. It's about consistency anyway.
…arget-has-atomic, r=alexcrichton Add compile test for cfg_target_has_atomic Issue rust-lang#39059. I am concerned about whether the test is excessive.
update mdbook version This contains two important bugfixes
…ook, r=frewsxcv sort unstable book alphabetically I made these the same order as they were in the compiler, but for no good reason. Much easier to find out what you need when they're sorted alphabetically r? @frewsxcv
|
@steveklabnik: no appropriate reviewer found, use r? to override |
|
@bors: r+ p=100 |
|
📌 Commit adb5183 has been approved by |
|
⌛ Testing commit adb5183 with merge 11db62c... |
|
💔 Test failed - status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.