mark build::cfg::start_new_block as inline(never) #41015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM has a bug - PR32488 - where it fails to deduplicate allocas in some circumstances. The function `start_new_block` has allocas totalling 1216 bytes, and when LLVM inlines several copies of that function into the recursive function `expr::into`, that function's stack space usage goes into tens of kiBs, causing stack overflows. Mark `start_new_block` as inline(never) to keep it from being inlined, getting stack usage under control. Fixes rust-lang#40493. Fixes rust-lang#40573.
arielb1
added
the
beta-nominated
Merged
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 3, 2017
[beta] Beta next - rust-lang#40764 - rust-lang#40809 - rust-lang#41015 r? @brson
alexcrichton
added
beta-accepted
|
@bors: r+ (already landed on beta anyway) |
|
📌 Commit 09ac56d has been approved by |
|
Nice job @arielb1 ! |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Apr 5, 2017
…hton mark build::cfg::start_new_block as inline(never) LLVM has a bug - [PR32488](https://bugs.llvm.org//show_bug.cgi?id=32488) - where it fails to deduplicate allocas in some circumstances. The function `start_new_block` has allocas totalling 1216 bytes, and when LLVM inlines several copies of that function into the recursive function `expr::into`, that function's stack space usage goes into tens of kiBs, causing stack overflows. Mark `start_new_block` as inline(never) to keep it from being inlined, getting stack usage under control. Fixes rust-lang#40493. Fixes rust-lang#40573. r? @eddyb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM has a bug - PR32488 - where it fails to deduplicate allocas in some
circumstances. The function
start_new_blockhas allocas totalling 1216bytes, and when LLVM inlines several copies of that function into
the recursive function
expr::into, that function's stack space usagegoes into tens of kiBs, causing stack overflows.
Mark
start_new_blockas inline(never) to keep it from being inlined,getting stack usage under control.
Fixes #40493.
Fixes #40573.
r? @eddyb