Stabilize float_bits_conv for Rust 1.20 #43055
Conversation
Mark-Simulacrum
added
the
T-libs-api
aidanhs
added
the
S-waiting-on-review
est31
changed the title
est31
force-pushed
the
stabilize_float_bits_conv
branch
from
b98547b
to
9fb16a6
Compare
|
I guess the 1.20 estimate is wrong because of the FCP which delays by >= 10 days and the new beta branches in a week already. 1.21 it is then! |
est31
force-pushed
the
stabilize_float_bits_conv
branch
from
9fb16a6
to
010dea1
Compare
|
friendly ping @BurntSushi! |
|
Doesn't FCP in #40470 need to finish first? |
|
Oh sorry, that wasn't clear in this issue. |
carols10cents
added
S-waiting-on-author
|
Is there any way to work around this in Rust 1.18? |
|
@i-dash what do you mean by that? Right now its possible to do such conversion with the help of unsafe Rust. Or have you stumbled into huonw/ieee754#2 ? For that, you can use a cargo replace, like doing the following in your Cargo.toml (maybe you need to adjust the version, also untested): [replace]
"ieee754:0.2.1" = { git = "https://github.com/clarcharr/ieee754" } |
|
r? @BurntSushi |
|
@bors r+ rollup |
|
📌 Commit 010dea1 has been approved by |
Stabilize float_bits_conv for Rust 1.21 Stabilizes the `float_bits_conv` lib feature for the 1.20 release of Rust. I've initially implemented the feature in #39271 and later made PR #43025 to output quiet NaNs even on platforms with different encodings, which seems to have been the only unresolved issue of the API. Due to PR #43025 being only applied to master this stabilisation can't happen for Rust 1.19 through the usual "stabilisation on beta" system that is being done for library APIs. r? @BurntSushi closes #40470.
|
☀️ Test successful - status-appveyor, status-travis |
alexcrichton
added
the
relnotes
alexcrichton
changed the title
Stabilizes the
float_bits_convlib feature for the 1.20 release of Rust. I've initially implemented the feature in #39271 and later made PR #43025 to output quiet NaNs even on platforms with different encodings, which seems to have been the only unresolved issue of the API.Due to PR #43025 being only applied to master this stabilisation can't happen for Rust 1.19 through the usual "stabilisation on beta" system that is being done for library APIs.
r? @BurntSushi
closes #40470.