Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support pub(restricted) in thread_local! (round 2) #43185

Merged
merged 4 commits into from
Jul 15, 2017

Conversation

durka
Copy link
Contributor

@durka durka commented Jul 12, 2017

Resurrected #40984 now that the issue blocking it was fixed. Original description:

pub(restricted) was stabilized in #40556 so let's go!

Here is a playground.

I changed the interface of __thread_local_inner!, which is supposedly unstable but this is not checked for macros (#34097 cc @petrochenkov @jseyfried), so this may be an issue.

@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@aidanhs aidanhs added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2017
@alexcrichton
Copy link
Member

@bors: r+

Thanks @durka!

@bors
Copy link
Contributor

bors commented Jul 14, 2017

📌 Commit f9f4707 has been approved by alexcrichton

@alexcrichton alexcrichton added the relnotes Marks issues that should be documented in the release notes of the next release. label Jul 14, 2017
@bors
Copy link
Contributor

bors commented Jul 15, 2017

⌛ Testing commit f9f4707 with merge 8658908...

bors added a commit that referenced this pull request Jul 15, 2017
support pub(restricted) in thread_local! (round 2)

Resurrected #40984 now that the issue blocking it was fixed. Original description:

`pub(restricted)` was stabilized in #40556 so let's go!

Here is a [playground](https://play.rust-lang.org/?gist=f55f32f164a6ed18c219fec8f8293b98&version=nightly&backtrace=1).

I changed the interface of `__thread_local_inner!`, which is supposedly unstable but this is not checked for macros (#34097 cc @petrochenkov @jseyfried), so this may be an issue.
@bors
Copy link
Contributor

bors commented Jul 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8658908 to master...

@bors bors merged commit f9f4707 into rust-lang:master Jul 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants