Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save selected search tab #45281

Merged
merged 1 commit into from
Oct 18, 2017
Merged

Save selected search tab #45281

merged 1 commit into from
Oct 18, 2017

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 14, 2017 •
edited
Loading

Fixes #45278.

r? @rust-lang/docs

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 14, 2017
@dns2utf8
Copy link
Contributor

Very cool 👍

kennytm
kennytm reviewed Oct 14, 2017
View reviewed changes
src/librustdoc/html/static/main.js Outdated
'<div>As return value</div></div><div id="results">';
`<div${currentTab === 0 ? ' class="selected"' : ""}>Types/modules</div>` +
`<div${currentTab === 1 ? ' class="selected"' : ""}>As parameters</div>` +
`<div${currentTab === 2 ? ' class="selected"' : ""}>As return value</div>` +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should use template literals?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent point!

@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 14, 2017
Merged
@GuillaumeGomez
Copy link
Member Author

Updated.

dns2utf8
dns2utf8 approved these changes Oct 15, 2017
View reviewed changes
Copy link
Contributor

@dns2utf8 dns2utf8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@QuietMisdreavus
Copy link
Member

@bors r+

I wonder how long it'll take until someone asks this to be saved to local storage. >_> Maybe that can be folded into an eventual settings page PR for #18167.

@bors
Copy link
Contributor

bors commented Oct 17, 2017

📌 Commit 45bb03f has been approved by QuietMisdreavus

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 17, 2017
@GuillaumeGomez
Copy link
Member Author

@QuietMisdreavus: Sounds like a strange idea... It's just a tab away. :p

kennytm added a commit to kennytm/rust that referenced this pull request Oct 18, 2017
@kennytm
Rollup merge of rust-lang#45281 - GuillaumeGomez:tab-selection, r=Qui…
4913b92 
…etMisdreavus

Save selected search tab

Fixes rust-lang#45278.

r? @rust-lang/docs
@kennytm kennytm mentioned this pull request Oct 18, 2017
Merged
bors added a commit that referenced this pull request Oct 18, 2017
@bors
Auto merge of #45368 - kennytm:rollup, r=kennytm
b796087 
Rollup of 10 pull requests

- Successful merges: #44138, #45082, #45098, #45181, #45217, #45281, #45325, #45326, #45340, #45354
- Failed merges:
@alexcrichton alexcrichton merged commit 45bb03f into rust-lang:master Oct 18, 2017
@GuillaumeGomez GuillaumeGomez deleted the tab-selection branch October 19, 2017 08:05
bors added a commit that referenced this pull request Oct 19, 2017
@bors
Auto merge of #45288 - GuillaumeGomez:tab-key-binding, r=QuietMisdreavus
a651106 
Save the highlighted item when switching tab

To be merged after #45281.

r? @rust-lang/docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm left review comments

@dns2utf8 dns2utf8 dns2utf8 approved these changes

Assignees
No one assigned
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @dns2utf8 @QuietMisdreavus @bors @kennytm @alexcrichton