incr.comp.: Some preparatory work for caching more query results. #46299
Conversation
carols10cents
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #44884) made this pull request unmergeable. Please resolve the merge conflicts. |
| for DecodeContext<'a, 'tcx> { | ||
| #[inline] | ||
| fn specialized_decode(&mut self) -> Result<mir::ClearCrossCrate<T>, Self::Error> { | ||
| Ok(mir::ClearCrossCrate::Clear) |
There was a problem hiding this comment.
that's...a cute trick
There was a problem hiding this comment.
Right? :)
I poached it from @arielb1.
|
r=me after rebase |
michaelwoerister
force-pushed
the
incr-comp-krimskrams
branch
from
2a2783b
to
3bb25d6
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 3bb25d6 has been approved by |
kennytm
added
S-waiting-on-bors
|
⌛ Testing commit 3bb25d6 with merge 1d1431789b75ee49dd1c3f506d409ce0b071efa2... |
|
💔 Test failed - status-travis |
|
Looks spurious. |
|
@bors p=1 (A while back we decided that incr. comp. PRs get higher priority until the end of the year. Since there are 4 incr. comp. PRs open in parallel at the moment, with more to come, I'm taking advantage of this now) |
…atsakis incr.comp.: Some preparatory work for caching more query results. This PR * adds and updates some encoding/decoding routines for various query result types so they can be cached later, and * adds missing `[input]` annotations for a few `DepNode` variants. The situation around having to explicitly mark dep-nodes/queries as inputs is not really satisfactory. I hope we can find a way of making this more fool-proof in the future. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
This PR
[input]annotations for a fewDepNodevariants.The situation around having to explicitly mark dep-nodes/queries as inputs is not really satisfactory. I hope we can find a way of making this more fool-proof in the future.
r? @nikomatsakis