Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. #46411

Merged
merged 1 commit into from
Dec 12, 2017
Merged

Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. #46411

merged 1 commit into from
Dec 12, 2017

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Nov 30, 2017

The ascii_methods_on_intrinsics feature stabilization
didn't land in time for 1.21.0. Update the annotation
so the documentation is correct about when these
methods became available.

@rust-highfive
Copy link
Collaborator

r? @Kimundi

(rust_highfive has picked a reviewer for you, use r? to override)

@rillian
Copy link
Contributor Author

rillian commented Nov 30, 2017

cc @LukasKalbertodt. This fixes an apparent oversight in #46411.

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Nov 30, 2017
@ollie27
Copy link
Member

ollie27 commented Nov 30, 2017

They're not in 1.22.0 either. 1.23.0 is the first version with these methods. Also, I assume you meant to link to #44042.

@rillian
Copy link
Contributor Author

rillian commented Nov 30, 2017

Oops, yes, that's correct. Thanks!

@rillian rillian force-pushed the str_ascii branch 2 times, most recently from 2949f54 to 6fdbf4b Compare November 30, 2017 20:35
@rillian rillian changed the title Mark ascii methods on primitive types stable in 1.22.0. Mark ascii methods on primitive types stable in 1.23.0. Nov 30, 2017
@rillian
Copy link
Contributor Author

rillian commented Dec 1, 2017

The documentation is also incorrect in 1.23.0 beta. Could someone please nominate this issue for inclusion there?

@bors
Copy link
Contributor

bors commented Dec 2, 2017

☔ The latest upstream changes (presumably #46288) made this pull request unmergeable. Please resolve the merge conflicts.

@rillian
Mark ascii methods on primitive types stable in 1.23.0.
6aef5e3 
The ascii_methods_on_intrinsics feature stabilization
didn't land in time for 1.21.0. Update the annotation
so the documentation is correct about when these
methods became available.
@rillian
Copy link
Contributor Author

rillian commented Dec 5, 2017

@Kimundi review ping?

@rillian
Copy link
Contributor Author

rillian commented Dec 8, 2017

r? @steveklabnik

@rust-highfive rust-highfive assigned steveklabnik and unassigned Kimundi Dec 8, 2017
@rillian rillian changed the title Mark ascii methods on primitive types stable in 1.23.0. Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0. Dec 8, 2017
@kennytm
Copy link
Member

kennytm commented Dec 11, 2017

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 11, 2017

📌 Commit 6aef5e3 has been approved by kennytm

@kennytm kennytm added beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2017
@bors
Copy link
Contributor

bors commented Dec 12, 2017

⌛ Testing commit 6aef5e3 with merge 3a0b652...

bors added a commit that referenced this pull request Dec 12, 2017
@bors
Auto merge of #46411 - rillian:str_ascii, r=kennytm
3a0b652 
Mark ascii methods on primitive types stable in 1.23.0 not 1.21.0.

The ascii_methods_on_intrinsics feature stabilization
didn't land in time for 1.21.0. Update the annotation
so the documentation is correct about when these
methods became available.
@rillian
Copy link
Contributor Author

rillian commented Dec 12, 2017

Thanks @kennytm! :D

@bors
Copy link
Contributor

bors commented Dec 12, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing 3a0b652 to master...

@bors bors merged commit 6aef5e3 into rust-lang:master Dec 12, 2017
@alexcrichton alexcrichton added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 19, 2017
@alexcrichton
Copy link
Member

Looks like we forgot to backport this to 1.23.0 (sorry about that!) so removing the beta tags.

@alexcrichton alexcrichton removed beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Jan 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@rillian @rust-highfive @ollie27 @bors @kennytm @alexcrichton @steveklabnik @Kimundi