Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIR Borrowck] Moveck inline asm statements #46975

Merged
merged 1 commit into from
Dec 26, 2017
Merged

[MIR Borrowck] Moveck inline asm statements #46975

merged 1 commit into from
Dec 26, 2017

Conversation

matthewjasper
Copy link
Contributor

Closes #45695

New behavior:

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @estebank (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matthewjasper matthewjasper changed the title Moveck inline asm statements [MIR Borrowck] Moveck inline asm statements Dec 23, 2017
@matthewjasper
Copy link
Contributor Author

r? @arielb1

@rust-highfive rust-highfive assigned arielb1 and unassigned estebank Dec 23, 2017
arielb1
arielb1 reviewed Dec 23, 2017
View reviewed changes
src/test/run-pass/asm-in-moved.rs Outdated
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// ignore-s390x
Copy link
Contributor

@arielb1 arielb1 Dec 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most tests use this instead:

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

see e.g. the asm-out-assign test

@arielb1
Copy link
Contributor

arielb1 commented Dec 23, 2017

r=me with tests fixed to use

#[cfg(any(target_arch = "x86", target_arch = "x86_64"))]

@matthewjasper
Copy link
Contributor Author

Done. The compile-fail test still uses ignore, as cfg isn't understood by the test-runner.

@arielb1
Copy link
Contributor

arielb1 commented Dec 24, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2017

📌 Commit 1a308ba has been approved by arielb1

@bors
Copy link
Contributor

bors commented Dec 25, 2017

⌛ Testing commit 1a308ba with merge 70836ed585280838f37f6da818f73c83f1576327...

@bors
Copy link
Contributor

bors commented Dec 25, 2017

💔 Test failed - status-travis

@estebank
Copy link
Contributor

@bors retry

@bors
Copy link
Contributor

bors commented Dec 25, 2017

⌛ Testing commit 1a308ba with merge 1f4a500b62c71bd87c5571a8ce3b76b91657f23e...

@bors
Copy link
Contributor

bors commented Dec 25, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Dec 25, 2017 •
edited
Loading

@bors retry #47002

@bors
Copy link
Contributor

bors commented Dec 26, 2017

⌛ Testing commit 1a308ba with merge d1bfe337f9ceced97d45f71f2f37efbe7b2c7b8a...

@bors
Copy link
Contributor

bors commented Dec 26, 2017

💔 Test failed - status-travis

@estebank
Copy link
Contributor

@bors retry

@bors
Copy link
Contributor

bors commented Dec 26, 2017

⌛ Testing commit 1a308ba with merge cddc4a6...

bors added a commit that referenced this pull request Dec 26, 2017
@bors
Auto merge of #46975 - matthewjasper:mir-moveck-asm, r=arielb1
cddc4a6 
[MIR Borrowck] Moveck inline asm statements

Closes #45695

New behavior:
* Input operands to `asm!` are moved, direct output operands are initialized.
* Direct, non-read-write outputs match the assignment changes in #46752 (Shallow writes, end borrows).
@bors
Copy link
Contributor

bors commented Dec 26, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: arielb1
Pushing cddc4a6 to master...

@bors bors merged commit 1a308ba into rust-lang:master Dec 26, 2017
@matthewjasper matthewjasper deleted the mir-moveck-asm branch September 3, 2018 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arielb1 arielb1 arielb1 left review comments

Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@matthewjasper @rust-highfive @arielb1 @bors @estebank @kennytm