Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in which we check for confusable Unicodepoints in float literal exponent #49989

Closed
wants to merge 1 commit into from
Closed

in which we check for confusable Unicodepoints in float literal exponent #49989

wants to merge 1 commit into from

Commits on Apr 15, 2018

  1. in which we check for confusable Unicodepoints in float literal exponent 

    The `FatalError.raise()` might seem unmotivated (in most places in
the compiler, `err.emit()` suffices), but it's actually used to
maintain behavior (viz., stop lexing, don't emit potentially spurious
errors looking for the next token after the bad Unicodepoint in the
exponent): the previous revision's `self.err_span_` ultimately calls
`Handler::emit`, which aborts if the `Handler`'s continue_after_error
flag is set, which seems to typically be true during lexing (see
`phase_1_parse_input` and and how `CompileController::basic` has
`continue_parse_after_error: false` in librustc_driver).

Also, let's avoid apostrophes in error messages (the present author
would argue that users expect a reassuringly detached, formal,
above-it-all tone from a Serious tool like a compiler), and use an
RLS-friendly structured suggestion.

Resolves rust-lang#49746.
    @zackmdavis
    zackmdavis committed Apr 15, 2018
    Configuration menu
    Copy the full SHA
    c94a42a View commit details
    Browse the repository at this point in the history