[beta] Process backports #51037
Merged
[beta] Process backports #51037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietroalbini
added
the
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
pietroalbini
force-pushed
the
beta-backports
branch
from
ddf9ce6
to
40d4676
Compare
This comment has been minimized.
This comment has been minimized.
pietroalbini
force-pushed
the
beta-backports
branch
from
1f83017
to
40d4676
Compare
|
@petrochenkov #50879 does not apply cleanly on the beta branch, can you please open a new PR with that? |
|
@pietroalbini |
|
Thanks @petrochenkov! Current PR status: both #51051 and #51011 needs to be approved before this PR can be merged. |
This comment has been minimized.
This comment has been minimized.
kennytm
added
S-blocked
|
It looks like #51052 is also not beta-accepted yet. |
|
Also added #51146, which fixes a regression and needs to be approved for backport by the compiler team. |
|
approved #51146 |
|
approved #51235 (reading issues really helps in understanding PRs -.-) that should be all of them |
|
Can someone r+ this? Don't have permissions myself. |
|
@bors delegate |
|
@bors r+ |
|
📌 Commit 64f813d has been approved by |
bors
added
S-waiting-on-bors
|
@bors p=1 (beta backports) |
bors
added a commit
that referenced
this pull request
Jun 1, 2018
[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50827: Update LLVM to `56c931901cfb85cd6f7ed44c7d7520a8de1edf97` * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in `impl Trait` methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 52a3735 with merge 145e6d2915c182eb00d33853e68de8259c7a90e9... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Ok, this failed again, so I guess it's LLVM fault. |
behavior when NaN is involved.
`PointerKind` is included in `LoanPath` and hence forms part of the equality check; this led to having two unequal paths that both represent `*x`, depending on whether the `*` was inserted automatically or explicitly. Bad mojo. The `note` field, in contrast, is intended more-or-less primarily for this purpose of adding extra data.
If a struct pattern has a field error return an error.
pietroalbini
force-pushed
the
beta-backports
branch
from
52a3735
to
724cfd8
Compare
|
Let's try without the LLVM backport. @bors r+ |
|
📌 Commit 724cfd8 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jun 3, 2018
[beta] Process backports Merged and approved: * #50812: Fix issue #50811 (`NaN > NaN` was true). * #50879: Fix naming conventions for new lints * #51011: rustdoc: hide macro export statements from docs * #51051: prohibit turbofish in impl Trait methods * #51052: restore emplacement syntax (obsolete) * #51146: typeck: Do not pass the field check on field error * #51235: remove notion of Implicit derefs from mem-cat r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged and approved:
NaN > NaNwas true). #50812: Fix issue NaN > NaN returns true #50811 (NaN > NaNwas true).impl Traitmethods #51051: prohibit turbofish in impl Trait methodsr? @ghost