rename rustc's lld to rust-lld #51936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to not shadow the system installed LLD when linking with LLD. Before: - `-C linker=lld -Z linker-flavor=ld.lld` uses rustc's LLD - It's not possible to use a system installed LLD that's named `lld` With this commit: - `-C linker=rust-lld -Z linker-flavor=ld.lld` uses rustc's LLD - `-C linker=lld -Z linker-flavor=ld.lld` uses the system installed LLD
rust-highfive
added
the
S-waiting-on-review
|
cc @phil-opp , i bet we'll need to update our target specs |
|
@bors: r+ |
|
📌 Commit 807cd36 has been approved by |
bors
added
S-waiting-on-bors
|
@steveklabnik Thanks for the heads up! |
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Jul 1, 2018
rename rustc's lld to rust-lld to not shadow the system installed LLD when linking with LLD. Before: - `-C linker=lld -Z linker-flavor=ld.lld` uses rustc's LLD - It's not possible to use a system installed LLD that's named `lld` With this commit: - `-C linker=rust-lld -Z linker-flavor=ld.lld` uses rustc's LLD - `-C linker=lld -Z linker-flavor=ld.lld` uses the system installed LLD we don't offer guarantees about the availability of LLD in the rustc sysroot so we can rename the tool as long as we don't break the wasm32-unknown-unknown target which depends on it. r? @alexcrichton we discussed this before
bors
added a commit
that referenced
this pull request
Jul 1, 2018
Rollup of 7 pull requests Successful merges: - #51511 (Stabilize Iterator::flatten in 1.29, fixes #48213.) - #51853 (Fix some doc links) - #51890 (Fix inconsequential typo in GlobalAlloc doc example) - #51920 (use literal span for concrete type suggestion) - #51922 (rename the llvm-tools component to llvm-tools-preview and tweak its image) - #51936 (rename rustc's lld to rust-lld) - #51961 (Fix typo in /src/librustc_resolve/lib.rs) Failed merges: r? @ghost
|
@bors r- |
bors
added
S-waiting-on-author
|
bors r=alexcrichton |
|
err, @bors r=alexcrichton |
|
📌 Commit 31ed5c7 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 5, 2018
rename rustc's lld to rust-lld to not shadow the system installed LLD when linking with LLD. Before: - `-C linker=lld -Z linker-flavor=ld.lld` uses rustc's LLD - It's not possible to use a system installed LLD that's named `lld` With this commit: - `-C linker=rust-lld -Z linker-flavor=ld.lld` uses rustc's LLD - `-C linker=lld -Z linker-flavor=ld.lld` uses the system installed LLD we don't offer guarantees about the availability of LLD in the rustc sysroot so we can rename the tool as long as we don't break the wasm32-unknown-unknown target which depends on it. r? @alexcrichton we discussed this before
|
☀️ Test successful - status-appveyor, status-travis |
steveklabnik
added a commit
to intermezzOS/kernel
that referenced
this pull request
Jul 9, 2018
steveklabnik
added a commit
to intermezzOS/book
that referenced
this pull request
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to not shadow the system installed LLD when linking with LLD.
Before:
-C linker=lld -Z linker-flavor=ld.llduses rustc's LLDlldWith this commit:
-C linker=rust-lld -Z linker-flavor=ld.llduses rustc's LLD-C linker=lld -Z linker-flavor=ld.llduses the system installed LLDwe don't offer guarantees about the availability of LLD in the rustc sysroot so we can rename the tool as long as we don't break the wasm32-unknown-unknown target which depends on it.
r? @alexcrichton we discussed this before