Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Rollup backports #52687

Merged
merged 13 commits into from
Jul 26, 2018
Merged

[beta] Rollup backports #52687

merged 13 commits into from
Jul 26, 2018

Conversation

pietroalbini
Copy link
Member

@pietroalbini pietroalbini commented Jul 25, 2018 •
edited by kennytm
Loading

Merged and approved:

r? @ghost

@pietroalbini
Copy link
Member Author

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 25, 2018

📌 Commit 425b5f4 has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 25, 2018
@bors
Copy link
Contributor

bors commented Jul 25, 2018

⌛ Testing commit 425b5f4 with merge 5d50b0e0bb5a4c6bf38f4d633ad6152613ab9c1e...

@rust-highfive

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Jul 25, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2018
@pietroalbini
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Jul 25, 2018

📌 Commit ffb0b2ec7df1b332e240d190cddfd343a8374e19 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2018
@bors
Copy link
Contributor

bors commented Jul 25, 2018

⌛ Testing commit ffb0b2ec7df1b332e240d190cddfd343a8374e19 with merge 2d966436143136a78192e18790d990ef2778b927...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jul 25, 2018

💔 Test failed - status-travis

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2018
bors added a commit that referenced this pull request Jul 25, 2018
@bors
Auto merge of #52687 - pietroalbini:beta-backports, r=pietroalbini
3fe4ada 
[beta] Rollup backports

Merged and approved:

* #52677: Release notes: add some missing 1.28 libs stabilization
* #52181: rustdoc: set panic output before starting compiler thread pool

r? @ghost
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 25, 2018
@kennytm
Rollup merge of rust-lang#52709 - cuviper:beta-global_allocator, r=al…
bbeca29 
…excrichton

beta: only true stage0 needs feature(global_allocator)

We use `#[global_allocator]` for `stage0` builds of libstd, and also
with `feature = "force_alloc_system"` that's set for a local rebuild,
where the bootstrap compiler is the same version and otherwise uses the
`--cfg stage1`.

We only need the unstable `feature(global_allocator)` for a true `stage0`
being 1.27.  For rebuilds with 1.28, that feature is stable and causes a
denied warning if it's enabled, so we should avoid it.
@kennytm
Copy link
Member

kennytm commented Jul 25, 2018

@bors r=pietroalbini p=95

Rolled up #52709 as well.

@bors
Copy link
Contributor

bors commented Jul 25, 2018

📌 Commit bbeca29 has been approved by pietroalbini

@bors
Copy link
Contributor

bors commented Jul 25, 2018

🌲 The tree is currently closed for pull requests below priority 99, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2018
@kennytm
Copy link
Member

kennytm commented Jul 26, 2018

@bors p=100

It's 9:30 in Berlin let's see how it's going on.

@bors
Copy link
Contributor

bors commented Jul 26, 2018

⌛ Testing commit bbeca29 with merge 027bc0acb31d8a8cf35f171800072091fbf25c01...

@kennytm
Copy link
Member

kennytm commented Jul 26, 2018

@bors r- retry

Nope.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 26, 2018
@kennytm
Copy link
Member

kennytm commented Jul 26, 2018 •
edited
Loading

@bors p=100 r=pietroalbini

Trying to remove all conditions on the macOS builds again.

@bors
Copy link
Contributor

bors commented Jul 26, 2018

📌 Commit 3fd3221 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 26, 2018
@bors
Copy link
Contributor

bors commented Jul 26, 2018

⌛ Testing commit 3fd3221 with merge 9daf7cb...

bors added a commit that referenced this pull request Jul 26, 2018
@bors
Auto merge of #52687 - pietroalbini:beta-backports, r=pietroalbini
9daf7cb 
[beta] Rollup backports

Merged and approved:

* #52677: Release notes: add some missing 1.28 libs stabilization
* #52181: rustdoc: set panic output before starting compiler thread pool
* #52709: beta: only true stage0 needs feature(global_allocator)

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 26, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing 9daf7cb to beta...

@bors bors merged commit 3fd3221 into rust-lang:beta Jul 26, 2018
@kennytm
Copy link
Member

kennytm commented Jul 26, 2018

Since Travis has brought back our macs, We should revert the last commit before promotion to stable.

@pietroalbini
Copy link
Member Author

I'll send a PR soon.

@pietroalbini pietroalbini deleted the beta-backports branch July 26, 2018 19:36
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pietroalbini @bors @rust-highfive @kennytm @Centril @SimonSapin @QuietMisdreavus @cuviper