-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move compile-fail
tests to ui
#53196
Merged
Merged
Commits on Aug 14, 2018
-
Check error-patterns on UI tests. Fixes rust-lang#52531.
Previously, even if no expected errors were supplied, if a test execution failed then supplied error patterns would not be checked. This commit modifies the conditional that determines whether error patterns or expected errors are checked to remedy this. Further, this commit modifies the error pattern checking logic so that each pattern is checked against all lines of the string. This is required for UI tests as the stderr is in JSON format - all on one line - so in the previous implementation when the first pattern was found on the first line (which was actually the entire error) then no other patterns would be found on subsequent lines (as there weren't any).
Configuration menu - View commit details
-
Copy full SHA for fe28bcf - Browse repository at this point
Copy the full SHA fe28bcfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b16a306 - Browse repository at this point
Copy the full SHA b16a306View commit details -
Updated new UI tests to pass with NLL compare-mode
These tests need a review to ensure that those marked as ignore-compare-mode-nll should be ignored and that this isn't a bug in NLL.
Configuration menu - View commit details
-
Copy full SHA for 3e0a407 - Browse repository at this point
Copy the full SHA 3e0a407View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3fc7ab2 - Browse repository at this point
Copy the full SHA 3fc7ab2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed79c31 - Browse repository at this point
Copy the full SHA ed79c31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ad663c - Browse repository at this point
Copy the full SHA 2ad663cView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc5a657 - Browse repository at this point
Copy the full SHA dc5a657View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e7b9b8 - Browse repository at this point
Copy the full SHA 8e7b9b8View commit details -
Normalize crateresolve1.rs to support different candidate ordering be…
…tween executions.
Configuration menu - View commit details
-
Copy full SHA for 003b5a8 - Browse repository at this point
Copy the full SHA 003b5a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c13eb4 - Browse repository at this point
Copy the full SHA 7c13eb4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a922642 - Browse repository at this point
Copy the full SHA a922642View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0cfc173 - Browse repository at this point
Copy the full SHA 0cfc173View commit details -
Configuration menu - View commit details
-
Copy full SHA for cd12c82 - Browse repository at this point
Copy the full SHA cd12c82View commit details -
Configuration menu - View commit details
-
Copy full SHA for 768998a - Browse repository at this point
Copy the full SHA 768998aView commit details -
Configuration menu - View commit details
-
Copy full SHA for b8b7a3c - Browse repository at this point
Copy the full SHA b8b7a3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7f7c1e - Browse repository at this point
Copy the full SHA f7f7c1eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b24645 - Browse repository at this point
Copy the full SHA 4b24645View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67ec37b - Browse repository at this point
Copy the full SHA 67ec37bView commit details -
Configuration menu - View commit details
-
Copy full SHA for d775e61 - Browse repository at this point
Copy the full SHA d775e61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b02656 - Browse repository at this point
Copy the full SHA 7b02656View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.