Fix of bug introduced by #53762 (tool_lints) #53887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
matthiaskrgr
reviewed
Sep 1, 2018
src/librustc/lint/context.rs
Outdated
| CheckLintNameResult::Tool(_) => unreachable!(), | ||
| CheckLintNameResult::Tool(result) => match result { | ||
| Err((Some(_), new_name)) => Some(sess.struct_warn(&format!( | ||
| "lint name `{}` is deprcated \ |
There was a problem hiding this comment.
deprcated -> deprecated ?
(also in tests)
|
@bors delegate+ r=me with the typo fix |
|
✌️ @flip1995 can now approve this pull request |
|
@bors r+ Just directly pushed a fix, since this fixes RLS which we want to land sooner rather than later. |
|
📌 Commit daa4364 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Sep 2, 2018
Fix of bug introduced by #53762 (tool_lints) Before implementing backwards compat for tool lints, the `Tool` case when parsing cmdline lints was unreachable. This changed with #53762. This fix is needed for rls test-pass. (@nrc) r? @Manishearth
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before implementing backwards compat for tool lints, the
Toolcase when parsing cmdline lints was unreachable. This changed with #53762.This fix is needed for rls test-pass. (@nrc)
r? @Manishearth