Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] Rollup backports #54037

Merged
merged 4 commits into from
Sep 9, 2018
Merged

[beta] Rollup backports #54037

merged 4 commits into from
Sep 9, 2018

Conversation

pietroalbini
Copy link
Member

Merged and approved:

r? @ghost

@pietroalbini
Copy link
Member Author

@bors r+ p=20

@bors
Copy link
Contributor

bors commented Sep 7, 2018

📌 Commit 520ec9b has been approved by pietroalbini

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 7, 2018
@rust-highfive

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2018

📌 Commit 8ac27c9a6a634437d3446d81d7f5fdfd64478a73 has been approved by pietroalbini

@rust-highfive

This comment has been minimized.

Sign in to view
@pietroalbini
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2018
@pietroalbini
Add license header to the new tests
0a56d80 
Beta still requires them.
@pietroalbini
Copy link
Member Author

@bors r+

@bors
Copy link
Contributor

bors commented Sep 7, 2018

📌 Commit 0a56d80 has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 7, 2018
@bors
Copy link
Contributor

bors commented Sep 7, 2018

⌛ Testing commit 0a56d80 with merge aed86c2b85ddab6ad0280f8f90b4ca72e3e9561d...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:52:25] running 1881 tests
[00:52:28] ....................................................................................................
[00:52:31] ....................................................................................................
[00:52:33] ....................................................................................................
[00:52:36] ..............................................................F.....................................
[00:52:42] ..................................................ii.iii............................................
[00:52:45] ...................................................................................i................
[00:52:48] ............................i.......................................................................
[00:52:52] ....................................................................................................
---
[00:53:08] .................................i..................................................................
[00:53:11] ....................................................................................................
[00:53:14] ....................................................................................................
[00:53:16] ....................................................................................................
-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail/cfg-empty-codemap/auxiliary" "-A" "unused"
[00:53:18] ------------------------------------------
[00:53:18] 
[00:53:18] ------------------------------------------
[00:53:18] stderr:
[00:53:18] stderr:
[00:53:18] ------------------------------------------
[00:53:18] error: invalid `--cfg` argument: `""` (expected `key` or `key="value"`)
[00:53:18] 
[00:53:18] ------------------------------------------
[00:53:18] 
[00:53:18] thread '[compile-fail] compile-fail/cfg-empty-codemap.rs' panicked at 'explicit panic', tools/compiletest/src/runtest.rs:3145:9
---
[00:53:18] 
[00:53:18] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:498:22
[00:53:18] 
[00:53:18] 
[00:53:18] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/compile-fail" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/compile-fail" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mod

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:01f10515
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Sep 7, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 7, 2018
@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 8, 2018
@pietroalbini
Copy link
Member Author

@bors r+ p=20

@bors
Copy link
Contributor

bors commented Sep 9, 2018

📌 Commit c26cd04 has been approved by pietroalbini

@bors bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 9, 2018
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 9, 2018
@bors
Copy link
Contributor

bors commented Sep 9, 2018

⌛ Testing commit c26cd04 with merge edfc72b...

bors added a commit that referenced this pull request Sep 9, 2018
@bors
Auto merge of #54037 - pietroalbini:beta-backports, r=pietroalbini
edfc72b 
[beta] Rollup backports

Merged and approved:

* #53893: Validate syntax of `cfg` attributes

r? @ghost
@bors
Copy link
Contributor

bors commented Sep 9, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: pietroalbini
Pushing edfc72b to beta...

@bors bors merged commit c26cd04 into rust-lang:beta Sep 9, 2018
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pietroalbini @bors @rust-highfive @kennytm @Centril @petrochenkov