Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny the overflowing_literals lint for the 2018 edition #54507

Merged
merged 2 commits into from
Sep 24, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/librustc_lint/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ use std::{i8, i16, i32, i64, u8, u16, u32, u64, f32, f64};
use syntax::{ast, attr};
use syntax::errors::Applicability;
use rustc_target::spec::abi::Abi;
use syntax::edition::Edition;
use syntax_pos::Span;
use syntax::source_map;

Expand All @@ -38,7 +39,8 @@ declare_lint! {
declare_lint! {
OVERFLOWING_LITERALS,
Warn,
"literal out of range for its type"
"literal out of range for its type",
Edition::Edition2018 => Deny
}

declare_lint! {
Expand Down
16 changes: 16 additions & 0 deletions src/test/ui/editions/edition-deny-overflowing-literals-2018.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright 2012 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// edition:2018

fn main() {
let x: u8 = 256;
//~^ error: literal out of range for u8
}
10 changes: 10 additions & 0 deletions src/test/ui/editions/edition-deny-overflowing-literals-2018.stderr
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
error: literal out of range for u8
--> $DIR/edition-deny-overflowing-literals-2018.rs:14:17
|
LL | let x: u8 = 256;
| ^^^
|
= note: #[deny(overflowing_literals)] on by default

error: aborting due to previous error