Rollup of 6 pull requests #54607
Closed
Rollup of 6 pull requests #54607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forward-port of rust-lang#54397, should have included it earlier!
The debuginfo tests are exposed to the environment in a couple of ways: the path to the gdb executable matters, as does the Python path used when loading lldb. This patch incorporates these paths into the hash that is written to the stamp file, so that changing the path will cause the tests to be re-run.
MSVC ignores these keywords for C/C++ and uses the standard system calling convention. Rust should do so as well. Fixes rust-lang#54569.
Add 1.29.1 release notes Forward-port of rust-lang#54397, should have included it earlier!
…k-Simulacrum Include path in stamp hash for debuginfo tests The debuginfo tests are exposed to the environment in a couple of ways: the path to the gdb executable matters, as does the Python path used when loading lldb. This patch incorporates these paths into the hash that is written to the stamp file, so that changing the path will cause the tests to be re-run.
…lexcrichton
ignore {std,fast,vector,this}call on non-x86 windows
MSVC ignores these keywords for C/C++ and uses the standard system
calling convention. Rust should do so as well.
Fixes rust-lang#54569.
Accept trailing comma in `cfg_attr` Fixes rust-lang#54463 (stable-to-beta regression)
…davis A few cleanups and minor improvements to typeck This PR complements rust-lang#54533, which was limited to `check`. - change a few `push` loops to `extend`s - prefer `to_owned` to `to_string` for string literals - prefer `if let` to `match` where only one branch matters - a few other minor improvements - whitespace fixes
Remove useless lifetimes from `Pin` `impl`s. These were evidently left in by accident when the new API was switched over to.
|
@bors r+ p=6 |
|
📌 Commit 557ddea has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 557ddea with merge 97f1ff37cb374fe615814efb1bda48751e6debb8... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
cfg_attr#54581 (Accept trailing comma incfg_attr)Pinimpls. #54598 (Remove useless lifetimes fromPinimpls.)Failed merges:
r? @ghost