Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support underscore as constant name #55015

Merged
merged 1 commit into from
Oct 14, 2018
Merged

Support underscore as constant name #55015

merged 1 commit into from
Oct 14, 2018

Conversation

dsciarra
Copy link
Contributor

Issue: #54912

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 12, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-5.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 
[00:49:28] .............................................................................i...................... 4200/4593
[00:49:31] .................................................................................................... 4300/4593
[00:49:35] ..................................................................................................F. 4400/4593
[00:49:37] .................................................................................................... 4500/4593
 "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/underscore_const_names/auxiliary" "-A" "unused"
[00:49:40] ------------------------------------------
[00:49:40] 
[00:49:40] ------------------------------------------
[00:49:40] stderr:
---
[00:49:40] 
[00:49:40] thread 'main' panicked at 'Some tests failed', tools/compiletest/src/main.rs:501:22
[00:49:40] 
[00:49:40] 
[00:49:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "-

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:00dcbd40
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2018
@petrochenkov
Copy link
Contributor

Thanks!
@bors r+

@bors
Copy link
Contributor

bors commented Oct 14, 2018

📌 Commit 406cbf1 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 14, 2018
@bors
Copy link
Contributor

bors commented Oct 14, 2018

⌛ Testing commit 406cbf1 with merge 2462a2d...

bors added a commit that referenced this pull request Oct 14, 2018
@bors
Auto merge of #55015 - dsciarra:underscores-constant-names, r=petroch…
2462a2d 
…enkov

Support underscore as constant name

Issue: #54912
@bors
Copy link
Contributor

bors commented Oct 14, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: petrochenkov
Pushing 2462a2d to master...

@bors bors merged commit 406cbf1 into rust-lang:master Oct 14, 2018
@bors bors mentioned this pull request Oct 14, 2018
Merged
@dsciarra dsciarra deleted the underscores-constant-names branch October 15, 2018 15:56
@Centril Centril mentioned this pull request May 30, 2019
Merged
@Centril Centril mentioned this pull request Jun 9, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dsciarra @rust-highfive @petrochenkov @bors @pnkfelix