-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 22 pull requests #57727
Rollup of 22 pull requests #57727
Commits on Dec 13, 2018
-
Remove confusing comment about ideally using
!
forc_void
Using `!` for `c_void` would have the problem that pointers and potentially references to an uninhabited type would be created, and at least for references this is UB. Also document in addition that newtype wrappers around `c_void` are not recommended for representing opaque types (as a workaround for `extern type` not being stable) but instead refer to the Nomicon.
Configuration menu - View commit details
-
Copy full SHA for 5eafae2 - Browse repository at this point
Copy the full SHA 5eafae2View commit details -
Update code comments of
c_void
to explain the reasoning for its cur……rent implementation We need at least two variants of the enum as otherwise the compiler complains about the #[repr(u8)] attribute and we also need at least one variant as otherwise the enum would be uninhabitated and dereferencing pointers to it would be UB. As such, mark the variants not unstable because they should not actually exist but because they are temporary implementation details until `extern type` is stable and can be used instead.
Configuration menu - View commit details
-
Copy full SHA for 8de8880 - Browse repository at this point
Copy the full SHA 8de8880View commit details
Commits on Jan 5, 2019
-
- Cleanup the `impl PartialEq<BookFormat> for Book` implementation - Implement `impl PartialEq<Book> for BookFormat` so it’s symmetric - Fixes rust-lang#53844. - Removes the last example since it appears to be redundant with the previous two examples.
Configuration menu - View commit details
-
Copy full SHA for 96678df - Browse repository at this point
Copy the full SHA 96678dfView commit details
Commits on Jan 6, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0d3dfdf - Browse repository at this point
Copy the full SHA 0d3dfdfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 319a2c1 - Browse repository at this point
Copy the full SHA 319a2c1View commit details -
Configuration menu - View commit details
-
Copy full SHA for bbbabdf - Browse repository at this point
Copy the full SHA bbbabdfView commit details
Commits on Jan 7, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 6c60662 - Browse repository at this point
Copy the full SHA 6c60662View commit details
Commits on Jan 12, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 423a5bb - Browse repository at this point
Copy the full SHA 423a5bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1445a06 - Browse repository at this point
Copy the full SHA 1445a06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0394dce - Browse repository at this point
Copy the full SHA 0394dceView commit details -
Configuration menu - View commit details
-
Copy full SHA for ebdd072 - Browse repository at this point
Copy the full SHA ebdd072View commit details
Commits on Jan 14, 2019
-
Support passing cflags/cxxflags/ldflags to LLVM build
This may be needed with some host compilers.
Configuration menu - View commit details
-
Copy full SHA for c663272 - Browse repository at this point
Copy the full SHA c663272View commit details -
Configuration menu - View commit details
-
Copy full SHA for f4ded5b - Browse repository at this point
Copy the full SHA f4ded5bView commit details
Commits on Jan 15, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e5e9867 - Browse repository at this point
Copy the full SHA e5e9867View commit details -
Configuration menu - View commit details
-
Copy full SHA for 096ca87 - Browse repository at this point
Copy the full SHA 096ca87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 93b5536 - Browse repository at this point
Copy the full SHA 93b5536View commit details -
Configuration menu - View commit details
-
Copy full SHA for ed717f3 - Browse repository at this point
Copy the full SHA ed717f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6046be4 - Browse repository at this point
Copy the full SHA 6046be4View commit details -
Configuration menu - View commit details
-
Copy full SHA for dabe86d - Browse repository at this point
Copy the full SHA dabe86dView commit details -
Configuration menu - View commit details
-
Copy full SHA for feda604 - Browse repository at this point
Copy the full SHA feda604View commit details -
Configuration menu - View commit details
-
Copy full SHA for aa1ce32 - Browse repository at this point
Copy the full SHA aa1ce32View commit details
Commits on Jan 16, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 32b2834 - Browse repository at this point
Copy the full SHA 32b2834View commit details -
A few items were referenced, but did not have links.
Configuration menu - View commit details
-
Copy full SHA for bd8ee51 - Browse repository at this point
Copy the full SHA bd8ee51View commit details -
Use
Lit
rather thanP<Lit>
inhir::ExprKind
.It's simpler and makes some benchmark run up to 1% faster. It also makes `hir::ExprKind` more like `ast::ExprKind` (which underwent the equivalent change in rust-lang#55777).
Configuration menu - View commit details
-
Copy full SHA for ae4b14e - Browse repository at this point
Copy the full SHA ae4b14eView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc45528 - Browse repository at this point
Copy the full SHA dc45528View commit details -
Fix release manifest generation
Jethro Beekman committedJan 16, 2019 Configuration menu - View commit details
-
Copy full SHA for 0772dbb - Browse repository at this point
Copy the full SHA 0772dbbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01d0ae9 - Browse repository at this point
Copy the full SHA 01d0ae9View commit details -
Configuration menu - View commit details
-
Copy full SHA for e4e8885 - Browse repository at this point
Copy the full SHA e4e8885View commit details
Commits on Jan 17, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 22251a8 - Browse repository at this point
Copy the full SHA 22251a8View commit details -
Add test for linking non-existent static library
AB1908 committedJan 17, 2019 Configuration menu - View commit details
-
Copy full SHA for 1e3f475 - Browse repository at this point
Copy the full SHA 1e3f475View commit details -
Configuration menu - View commit details
-
Copy full SHA for fefe1da - Browse repository at this point
Copy the full SHA fefe1daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3884cc8 - Browse repository at this point
Copy the full SHA 3884cc8View commit details -
Add signed num::NonZeroI* types
Multiple people have asked for them, in rust-lang#49137. Given that the unsigned ones already exist, they are very easy to add and not an additional maintenance burden.
Configuration menu - View commit details
-
Copy full SHA for 9be4c76 - Browse repository at this point
Copy the full SHA 9be4c76View commit details -
Configuration menu - View commit details
-
Copy full SHA for d34b3e9 - Browse repository at this point
Copy the full SHA d34b3e9View commit details
Commits on Jan 18, 2019
-
Fix suggestions given mulitple bad lifetimes
When given multiple lifetimes prior to type parameters in generic parameters, do not ICE and print the correct suggestion.
Configuration menu - View commit details
-
Copy full SHA for e3ba6ed - Browse repository at this point
Copy the full SHA e3ba6edView commit details -
Rollup merge of rust-lang#56594 - sdroege:c_void-is-not-never, r=TimNN
Remove confusing comment about ideally using `!` for `c_void` Using `!` for `c_void` would have the problem that pointers and potentially references to an uninhabited type would be created, and at least for references this is UB. In addition document that newtype wrappers around `c_void` can be used safely in place of `extern type` until the latter is stabilized. ---- I'm not 100% sure about the usage for opaque types as the [nomicon](https://doc.rust-lang.org/nomicon/ffi.html#representing-opaque-structs) still recommends using `#[repr(C)] pub struct Foo { _private: [u8; 0] }` but it seems like these two should be equivalent in the end? Also the `#[repr(C)]` (in both cases) should be unneeded because such types never being passed by value, never being dereferenced but only passed around as pointer or reference, so the representation of (*values* of) the type itself should not matter at all? Also in context of `c_void` and `!` the second unresolved question in the [`extern type`](rust-lang#43467) stabilization ticket seems relevant > In [std's](https://github.com/rust-lang/rust/blob/164619a8cfe6d376d25bd3a6a9a5f2856c8de64d/src/libstd/os/raw.rs#L59-L64) source, it is mentioned that LLVM expects i8* for C's void*. > We'd need to continue to hack this for the two c_voids in std and libc. > But perhaps this should be done across-the-board for all extern types? > Somebody should check what Clang does. Please correct me if my understanding is wrong and everything's actually fine as is.
Configuration menu - View commit details
-
Copy full SHA for 33d64b0 - Browse repository at this point
Copy the full SHA 33d64b0View commit details -
Rollup merge of rust-lang#57107 - mjbshaw:thread_local_test, r=nikoma…
…tsakis Add a regression test for mutating a non-mut #[thread_local] This should close rust-lang#54901 since the regression has since been fixed.
Configuration menu - View commit details
-
Copy full SHA for 2b8d02f - Browse repository at this point
Copy the full SHA 2b8d02fView commit details -
Rollup merge of rust-lang#57340 - eqrion:doc/c_variadic, r=Mark-Simul…
…acrum Use correct tracking issue for c_variadic Fixes rust-lang#57306
Configuration menu - View commit details
-
Copy full SHA for 48a2f37 - Browse repository at this point
Copy the full SHA 48a2f37View commit details -
Rollup merge of rust-lang#57357 - frewsxcv:frewsxcv-partial-eq, r=Qui…
…etMisdreavus Cleanup PartialEq docs. - Cleanup the `impl PartialEq<BookFormat> for Book` implementation - Implement `impl PartialEq<Book> for BookFormat` so it’s symmetric - Fixes rust-lang#53844. - Removes the last example since it appears to be redundant with the previous two examples.
Configuration menu - View commit details
-
Copy full SHA for c3c5d66 - Browse repository at this point
Copy the full SHA c3c5d66View commit details -
Rollup merge of rust-lang#57370 - petrhosek:llvm-flags, r=alexcrichton
Support passing cflags/cxxflags/ldflags to LLVM build This may be needed with some host compilers.
Configuration menu - View commit details
-
Copy full SHA for 845106f - Browse repository at this point
Copy the full SHA 845106fView commit details -
Rollup merge of rust-lang#57475 - SimonSapin:signed, r=alexcrichton
Add signed num::NonZeroI* types Multiple people have asked for them in rust-lang#49137. Given that the unsigned ones already exist, they are very easy to add and not an additional maintenance burden.
Configuration menu - View commit details
-
Copy full SHA for dd545ee - Browse repository at this point
Copy the full SHA dd545eeView commit details -
Rollup merge of rust-lang#57501 - petrochenkov:highvar, r=alexreg
High priority resolutions for associated variants In rust-lang#56225 variants were assigned lowest priority during name resolution to avoid crater run and potential breakage. This PR changes the rules to give variants highest priority instead. Some motivation: - If variants (and their constructors) are treated as associated items, then they are obviously *inherent* associated items since they don't come from traits. - Inherent associated items have higher priority during resolution than associated items from traits. - The reason is that there is a way to disambiguate in favor of trait items (`<Type as Trait>::Ambiguous`), but there's no way to disambiguate in favor of inherent items, so they became unusable in case of ambiguities if they have low priority. - It's technically problematic to fallback from associated types to anything until lazy normalization (?) is implemented. Crater found some regressions from this change, but they are all in type positions, e.g. ```rust fn f() -> Self::Ambiguos { ... } // Variant `Ambiguous` or associated type `Ambiguous`? ``` , so variants are not usable there right now, but they may become usable in the future if rust-lang/rfcs#2593 is accepted. This PR keeps code like this successfully resolving, but introduces a future-compatibility lint `ambiguous_associated_items` that recommends rewriting it as `<Self as Trait>::Ambiguous`.
Configuration menu - View commit details
-
Copy full SHA for b025f26 - Browse repository at this point
Copy the full SHA b025f26View commit details -
Rollup merge of rust-lang#57551 - petrochenkov:regrtest, r=nikomatsakis
resolve: Add a test for issue rust-lang#57539 Add a test for the bugfix regression reported in rust-lang#57539 Closes rust-lang#57539
Configuration menu - View commit details
-
Copy full SHA for 6b0d66b - Browse repository at this point
Copy the full SHA 6b0d66bView commit details -
Rollup merge of rust-lang#57610 - mark-i-m:nested-matchers, r=petroch…
…enkov Fix nested `?` matchers fix rust-lang#57597 I'm not 100% if this works yet... cc @alercah When this is ready (but perhaps not yet):
Configuration menu - View commit details
-
Copy full SHA for 53f7e66 - Browse repository at this point
Copy the full SHA 53f7e66View commit details -
Rollup merge of rust-lang#57634 - oli-obk:remove_unused_argument, r=d…
…avidtwco Remove an unused function argument The only use was a debug printing, which might help someone with debugging dataflow problems, but seems otherwise useless
Configuration menu - View commit details
-
Copy full SHA for e964ca7 - Browse repository at this point
Copy the full SHA e964ca7View commit details -
Rollup merge of rust-lang#57635 - euclio:path-separators, r=michaelwo…
…erister use structured macro and path resolve suggestions
Configuration menu - View commit details
-
Copy full SHA for f4b8998 - Browse repository at this point
Copy the full SHA f4b8998View commit details -
Rollup merge of rust-lang#57636 - GuillaumeGomez:fix-sources-sidebar,…
… r=QuietMisdreavus Fix sources sidebar not showing up Fixes rust-lang#57601. The order of imports made it so that the sidebar creation was called before the sidebar sources were created. Like this, when the sources are loaded, they create the sidebar as expected. r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 4d29cca - Browse repository at this point
Copy the full SHA 4d29ccaView commit details -
Rollup merge of rust-lang#57646 - GuillaumeGomez:fix-css, r=QuietMisd…
…reavus Fixes text becoming invisible when element targetted Fixes rust-lang#57628. r? @QuietMisdreavus
Configuration menu - View commit details
-
Copy full SHA for 67386f0 - Browse repository at this point
Copy the full SHA 67386f0View commit details -
Rollup merge of rust-lang#57649 - petrochenkov:privexist, r=arielb1
privacy: Account for associated existential types Turns out they *can* be associated (but only in impls, not traits). Fixes rust-lang#53546 (comment) r? @arielb1
Configuration menu - View commit details
-
Copy full SHA for e8f2aec - Browse repository at this point
Copy the full SHA e8f2aecView commit details -
Rollup merge of rust-lang#57650 - AB1908:master, r=petrochenkov
librustc_metadata: Pass a default value when unwrapping a span Fixes rust-lang#57323. When compiling with `static-nobundle` a-la `rustc -l static-nobundle=nonexistent main.rs` we now get a neat output in the form of: ``` error[E0658]: kind="static-nobundle" is feature gated (see issue rust-lang#37403) | = help: add #![feature(static_nobundle)] to the crate attributes to enable error: aborting due to previous error For more information about this error, try `rustc --explain E0658`. ``` The build and tests completed successfully on my machine. Should I be adding a new test?
Configuration menu - View commit details
-
Copy full SHA for f7f5450 - Browse repository at this point
Copy the full SHA f7f5450View commit details -
Rollup merge of rust-lang#57654 - ehuss:fs-links, r=alexcrichton
Add some links in std::fs. A few items were referenced, but did not have links.
Configuration menu - View commit details
-
Copy full SHA for 7eabbdd - Browse repository at this point
Copy the full SHA 7eabbddView commit details -
Rollup merge of rust-lang#57658 - nnethercote:rm-hir-P-Lit, r=michael…
…woerister Two HIR tweaks Two HIR tweaks that make things slightly simpler and faster.
Configuration menu - View commit details
-
Copy full SHA for 00c582e - Browse repository at this point
Copy the full SHA 00c582eView commit details -
Rollup merge of rust-lang#57659 - jethrogb:jb/release-manifest, r=ale…
…xcrichton Fix release manifest generation r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for f451b6a - Browse repository at this point
Copy the full SHA f451b6aView commit details -
Rollup merge of rust-lang#57683 - xfix:patch-15, r=QuietMisdreavus
Document Unpin in std::prelude documentation
Configuration menu - View commit details
-
Copy full SHA for 3135ddb - Browse repository at this point
Copy the full SHA 3135ddbView commit details -
Rollup merge of rust-lang#57685 - pthariensflame:enhancement/pin-impl…
…-applicability, r=withoutboats Enhance `Pin` impl applicability for `PartialEq` and `PartialOrd`. This allows for comparing for equality or ordering a `Pin<P>` and a `Pin<Q>` as long as `P` and `Q` are correspondingly comparable themselves *even when `P` and `Q` are different types*. An example might be comparing a `Pin<&mut OsString>` to a `Pin<&mut PathBuf>`, which might arise from pin projections from a pair of larger contexts that aren't `Unpin`.
Configuration menu - View commit details
-
Copy full SHA for 06786bb - Browse repository at this point
Copy the full SHA 06786bbView commit details -
Rollup merge of rust-lang#57698 - michaelwoerister:issue57692, r=Zoxc
Fix typo bug in DepGraph::try_mark_green(). r? @Zoxc Fixes rust-lang#57692.
Configuration menu - View commit details
-
Copy full SHA for 0340cf4 - Browse repository at this point
Copy the full SHA 0340cf4View commit details -
Rollup merge of rust-lang#57720 - dlrobertson:fix_57521, r=estebank
Fix suggestions given mulitple bad lifetimes When given multiple lifetimes prior to type parameters in generic parameters, do not ICE and print the correct suggestion. r? @estebank CC @pnkfelix Fixes: rust-lang#57521
Configuration menu - View commit details
-
Copy full SHA for ca72ad1 - Browse repository at this point
Copy the full SHA ca72ad1View commit details