Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #57955

Closed
wants to merge 10 commits into from
Closed

Rollup of 5 pull requests #57955

wants to merge 10 commits into from

Commits on Jan 22, 2019

  1. Configuration menu
    Copy the full SHA
    2ec0e85 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2019

  1. Configuration menu
    Copy the full SHA
    0cf9704 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. Configuration menu
    Copy the full SHA
    c375333 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2019

  1. Configuration menu
    Copy the full SHA
    5e67021 View commit details
    Browse the repository at this point in the history
  2. Update visibility of intermediate use items.

    Currently, the target of a use statement will be updated with
    the visibility of the use statement itself (if the use statement was
    visible).
    
    This commit ensures that if the path to the target item is via another
    use statement then that intermediate use statement will also have the
    visibility updated like the target. This silences incorrect
    `unreachable_pub` lints with inactionable suggestions.
    davidtwco committed Jan 28, 2019
    Configuration menu
    Copy the full SHA
    ad22de4 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#57833 - jethrogb:jb/thread-spawn-unwrap, r=…

    …alexcrichton
    
    Print a slightly clearer message when failing to launch a thread
    
    As discussed in rust-lang#46345, the `io::Error` you get when a thread fails to launch is of type `io::ErrorKind::WouldBlock`. This is super uninformative when an arbitrary `thread::spawn` fails somewhere in your code:
    
    ```
    thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 11,
    kind: WouldBlock, message: "operation would block" }', src/libcore/result.rs:997:5
    ```
    
    This PR improves the situation a little bit by using `expect` instead of `unwrap`. I don't consider this a complete fix for rust-lang#46345 though.
    Centril authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    2a63b33 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#57859 - GuillaumeGomez:fix-background, r=Qu…

    …ietMisdreavus
    
    Fix invalid background color
    
    As discussed in rust-lang#57814.
    
    r? @QuietMisdreavus
    Centril authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    757abfc View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#57904 - euclio:attribute-typos, r=davidtwco

    add typo suggestion to unknown attribute error
    
    Provides a suggestion using Levenshtein distance to suggest built-in attributes and attribute macros.
    
    Fixes rust-lang#49270.
    Centril authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    5a6db2b View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#57915 - petrochenkov:notto-disu, r=zackmdavis

    Pretty print `$crate` as `crate` or `crate_name` in more cases
    
    So, people do parse output of `--pretty=expanded` (sigh), so covering only the legacy proc-macro case (like it was done in rust-lang#57155) is not enough.
    
    This PRs resolves all `$crate`s produced by macros, so they are all printed in the parseable form `$crate::foo` -> `crate::foo` or `crate_name::foo`.
    
    Fixes rust-lang#38016 (comment)
    Fixes rust-lang#57155 (comment)
    Centril authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    b194206 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#57922 - davidtwco:issue-57410, r=petrochenkov

    Update visibility of intermediate use items.
    
    Fixes rust-lang#57410 and fixes rust-lang#53925 and fixes rust-lang#47816.
    
    Currently, the target of a use statement will be updated with
    the visibility of the use statement itself (if the use statement was
    visible).
    
    This PR ensures that if the path to the target item is via another
    use statement then that intermediate use statement will also have the
    visibility updated like the target. This silences incorrect
    `unreachable_pub` lints with inactionable suggestions.
    Centril authored Jan 28, 2019
    Configuration menu
    Copy the full SHA
    ae34f21 View commit details
    Browse the repository at this point in the history