Add missing fmt structs examples #58538

GuillaumeGomez · 2019-02-17T14:56:23Z

r? @rust-lang/docs

src/libcore/fmt/builders.rs

Centril · 2019-02-18T05:11:25Z

src/libcore/fmt/builders.rs

+    /// struct Foo(Vec<(String, i32)>);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:08:55Z

src/libcore/fmt/builders.rs

+    ///         fmt.debug_struct("Bar")
+    ///            .field("bar", &self.bar)
+    ///            .field("baz", &self.baz)
+    ///            .finish() // You need to call it in order to "finish" the


Suggested change

/// .finish() // You need to call it in order to "finish" the

/// .finish() // You need to call it to "finish" the

Centril · 2019-02-18T06:09:28Z

src/libcore/fmt/builders.rs

+    /// }
+    ///
+    /// impl fmt::Debug for Bar {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:09:43Z

src/libcore/fmt/builders.rs

+    /// }
+    ///
+    /// impl fmt::Debug for Bar {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:10:00Z

src/libcore/fmt/builders.rs

+    /// struct Foo(i32, String);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:11:21Z

src/libcore/fmt/builders.rs

+    /// struct Foo(Vec<i32>, Vec<u32>);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:11:29Z

src/libcore/fmt/builders.rs

+    /// struct Foo(Vec<i32>);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:11:39Z

src/libcore/fmt/builders.rs

+    /// struct Foo(Vec<(String, i32)>);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:11:53Z

src/libcore/fmt/builders.rs

+    /// struct Foo(Vec<(String, i32)>);
+    ///
+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {


Suggested change

/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {

/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

Centril · 2019-02-18T06:14:46Z

src/libcore/fmt/builders.rs

+    /// impl fmt::Debug for Foo {
+    ///     fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
+    ///         fmt.debug_map()
+    ///            .entry(&"whole", &self.0) // We add the "whole" entry


Suggested change

/// .entry(&"whole", &self.0) // We add the "whole" entry

/// .entry(&"whole", &self.0) // We add the "whole" entry.

Centril · 2019-02-18T06:16:00Z

r? @Centril

r=me with nits addressed.

GuillaumeGomez · 2019-02-19T14:28:15Z

@bors: r=Centril rollup

bors · 2019-02-19T14:28:18Z

📌 Commit 31ee20d has been approved by Centril

Add missing fmt structs examples r? @rust-lang/docs

Rollup of 24 pull requests Successful merges: - #56470 (Modify doctest's auto-`fn main()` to allow `Result`s) - #58044 (Make overflowing and wrapping negation const) - #58303 (Improve stability tags display) - #58336 (Fix search results interactions) - #58384 (Fix tables display) - #58392 (Use less explicit shifting in std::net::ip) - #58409 (rustdoc: respect alternate flag when formatting impl trait) - #58456 (Remove no longer accurate diagnostic code about NLL) - #58528 (Don't use an allocation for ItemId in StmtKind) - #58530 (Monomorphize less code in fs::{read|write}) - #58534 (Mention capping forbid lints) - #58536 (Remove UB in pointer tests) - #58538 (Add missing fmt structs examples) - #58539 (Add alias methods to PathBuf for underlying OsString (#58234)) - #58544 (Fix doc for rustc "-g" flag) - #58545 (Add regression test for a specialization-related ICE (#39448)) - #58546 (librustc_codegen_llvm => 2018) - #58551 (Explain a panic in test case net::tcp::tests::double_bind) - #58553 (Use more impl header lifetime elision) - #58562 (Fix style nits) - #58565 (Fix typo in std::future::Future docs) - #58568 (Fix a transposition in driver.rs.) - #58569 (Reduce Some Code Repetitions like `(n << amt) >> amt`) - #58576 (Stabilize iter::successors and iter::from_fn)

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 17, 2019

fbstj reviewed Feb 17, 2019

View reviewed changes

src/libcore/fmt/builders.rs Outdated Show resolved Hide resolved

ollie27 reviewed Feb 17, 2019

View reviewed changes

src/libcore/fmt/builders.rs Outdated Show resolved Hide resolved

GuillaumeGomez force-pushed the fmt-examples branch from 9b0f70f to c01656d Compare February 17, 2019 21:36

Centril reviewed Feb 18, 2019

View reviewed changes

rust-highfive assigned Centril Feb 18, 2019

Add missing fmt structs examples

31ee20d

GuillaumeGomez force-pushed the fmt-examples branch from c01656d to 31ee20d Compare February 19, 2019 10:20

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 19, 2019

kennytm mentioned this pull request Feb 19, 2019

Rollup of 24 pull requests #58578

Merged

kennytm added a commit to kennytm/rust that referenced this pull request Feb 20, 2019

Rollup merge of rust-lang#58538 - GuillaumeGomez:fmt-examples, r=Centril

a68a1c7

Add missing fmt structs examples r? @rust-lang/docs

bors merged commit 31ee20d into rust-lang:master Feb 20, 2019

GuillaumeGomez deleted the fmt-examples branch February 20, 2019 17:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add missing fmt structs examples #58538

Add missing fmt structs examples #58538

GuillaumeGomez commented Feb 17, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril Feb 18, 2019

Centril commented Feb 18, 2019

GuillaumeGomez commented Feb 19, 2019

bors commented Feb 19, 2019

	/// fn fmt(&self, fmt: &mut fmt::Formatter) -> fmt::Result {
	/// fn fmt(&self, fmt: &mut fmt::Formatter<'_>) -> fmt::Result {

	/// .finish() // You need to call it in order to "finish" the
	/// .finish() // You need to call it to "finish" the

	/// .entry(&"whole", &self.0) // We add the "whole" entry
	/// .entry(&"whole", &self.0) // We add the "whole" entry.

Add missing fmt structs examples #58538

Add missing fmt structs examples #58538

Conversation

GuillaumeGomez commented Feb 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Centril commented Feb 18, 2019

GuillaumeGomez commented Feb 19, 2019

bors commented Feb 19, 2019