Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated RELEASES.md for 1.34.0 #59599

Merged
merged 3 commits into from
Apr 6, 2019
Merged

Updated RELEASES.md for 1.34.0 #59599

merged 3 commits into from
Apr 6, 2019

Conversation

XAMPPRocky
Copy link
Member

Rendered

This also corrects an omission in the previous 1.33.0 release.

r? @Mark-Simulacrum

cc @rust-lang/release

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2019
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Centril Centril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to @steveklabnik & et. al -- I think these should be our headline items in order of importance (0. being most important) in the blog post.

RELEASES.md Outdated

Cargo
-----
- [You can now use alternatives registries to crates.io.][cargo/6654]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compatibility Notes
-------------------
- [`Command::before_exec` is now deprecated in favor of the
unsafe method `Command::pre_exec`.][58059]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Misc
----
- [You can now use the `?` operator in your documentation tests without manually
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- [You can now use `#[deprecation = "reason"]`][58166] as a shorthand for
`#[deprecation(note = "reason")]`. This was previously allowed as a syntax bug
but had no effect.
- [You can now accept token streams in `#[attr()]`,`#[attr[]]`, and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASES.md Outdated Show resolved Hide resolved
RELEASES.md Show resolved Hide resolved
@kennytm kennytm added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 1, 2019
@jonas-schievink jonas-schievink added the T-release Relevant to the release subteam, which will review and decide on the PR/issue. label Apr 1, 2019
@pietroalbini pietroalbini added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 2, 2019
@crlf0710
Copy link
Member

crlf0710 commented Apr 4, 2019

Out-of-topic: Speaking of targets, i think https://forge.rust-lang.org/platform-support.html has been out of date for quite a while... targets such as uefi have never been labeled a tier, and added to the table :(

@pietroalbini
Copy link
Member

Can we get this finished up for the release?

Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@Mark-Simulacrum
Copy link
Member

@bors r+

Not giving priority as it landing on beta is more important -- master can wait.

@bors
Copy link
Contributor

bors commented Apr 5, 2019

📌 Commit 4ba3034 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
Updated RELEASES.md for 1.34.0

[Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md)

This also corrects an omission in the previous 1.33.0 release.

r? @Mark-Simulacrum

cc @rust-lang/release
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
Updated RELEASES.md for 1.34.0

[Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md)

This also corrects an omission in the previous 1.33.0 release.

r? @Mark-Simulacrum

cc @rust-lang/release
bors added a commit that referenced this pull request Apr 5, 2019
Rollup of 6 pull requests

Successful merges:

 - #58894 (Fix invalid bounds string generation in rustdoc)
 - #59599 (Updated RELEASES.md for 1.34.0)
 - #59624 (SGX target: Use linker option to avoid code CGU assignment kludge)
 - #59696 (Remove invalid assertion back::link::from add_upstream_rust_crates().)
 - #59707 (Add missing tryfrom example)
 - #59727 (wasi: Use shared API for preopened fds)

Failed merges:

r? @ghost
@bors bors merged commit 4ba3034 into rust-lang:master Apr 6, 2019
bors added a commit that referenced this pull request Apr 7, 2019
[beta] Rollup backports

Cherry-picked:

* #58021: Fix fallout from #57667
* #59599: Updated RELEASES.md for 1.34.0
* #59587: Remove #[doc(hidden)] from Error::type_id
* #58994: Hide deprecation warnings inside derive expansions
* #58015: Expand docs for `TryFrom` and `TryInto`.
* #59770: ci: pin android emulator to 28.0.23
* #59704: ci: Update FreeBSD tarball downloads
* #59257: Update CI configuration for building Redox libraries
* #59724: Function arguments should never get promoted

r? @ghost
bors added a commit that referenced this pull request Apr 8, 2019
[beta] Rollup backports

Cherry-picked:

* #58021: Fix fallout from #57667
* #59599: Updated RELEASES.md for 1.34.0
* #59587: Remove #[doc(hidden)] from Error::type_id
* #58994: Hide deprecation warnings inside derive expansions
* #58015: Expand docs for `TryFrom` and `TryInto`.
* #59770: ci: pin android emulator to 28.0.23
* #59704: ci: Update FreeBSD tarball downloads
* #59257: Update CI configuration for building Redox libraries
* #59724: Function arguments should never get promoted
* #59499: Fix broken download link in the armhf-gnu image
* #58330: Add rustdoc JS non-std tests
* #58848: Prevent cache issues on version updates

r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.