Opaque type locations in error message for clarity. #64157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
This looks like a nice improvement, thanks! @bors r+ |
|
📌 Commit fe2c6b1 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
…ramertj Opaque type locations in error message for clarity. Attempts to fix rust-lang#63167
Centril
reviewed
Sep 5, 2019
gilescope
force-pushed
the
opaque-type-location
branch
from
fe2c6b1
to
9483db5
Compare
|
@bors r=cramertj,Centril |
|
📌 Commit 9483db5 has been approved by |
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
…ramertj,Centril Opaque type locations in error message for clarity. Attempts to fix rust-lang#63167
Centril
added a commit
to Centril/rust
that referenced
this pull request
Sep 5, 2019
…ramertj,Centril Opaque type locations in error message for clarity. Attempts to fix rust-lang#63167
bors
added a commit
that referenced
this pull request
Sep 5, 2019
Rollup of 11 pull requests Successful merges: - #62848 (Use unicode-xid crate instead of libcore) - #63774 (Fix `window.hashchange is not a function`) - #63930 (Account for doc comments coming from proc macros without spans) - #64003 (place: Passing `align` = `layout.align.abi`, when also passing `layout`) - #64030 (Fix unlock ordering in SGX synchronization primitives) - #64041 (use TokenStream rather than &[TokenTree] for built-in macros) - #64051 (Add x86_64-linux-kernel target) - #64063 (Fix const_err with `-(-0.0)`) - #64083 (Point at appropriate arm on type error on if/else/match with one non-! arm) - #64100 (Fix const eval bug breaking run-pass tests in Miri) - #64157 (Opaque type locations in error message for clarity.) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #63167