Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: Some crate loading cleanup #65026

Merged
merged 7 commits into from
Oct 4, 2019
Merged

metadata: Some crate loading cleanup #65026

merged 7 commits into from
Oct 4, 2019

Commits on Oct 3, 2019

  1. metadata: Remove CrateMetadata::imported_name 

    It's entirely irrelevant to crate loading
    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    b507971 View commit details
    Browse the repository at this point in the history

  2. metadata: Do not pass crate name after renaming to register_crate 

    It's entirely irrelevant to crate loading
    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    acd102a View commit details
    Browse the repository at this point in the history

  3. metadata: Remove locator::Context::ident 

    It's a crate name after renaming, so it's entirely irrelevant to crate loading
    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    33c9ada View commit details
    Browse the repository at this point in the history

  4. metadata: Simplify interface of resolve_crate

    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    92386a7 View commit details
    Browse the repository at this point in the history

  5. metadata: Remove CrateMetadata::host_lib 

    It was only used for retreiving edition, which was a bug.
In case of dual proc macros the edition should be taken from the target crate version, like any other metadata.
    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    f13adc5 View commit details
    Browse the repository at this point in the history

  6. metadata: Remove CrateMetadata::name 

    It duplicates `CrateRoot::name`
    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    0f96ba9 View commit details
    Browse the repository at this point in the history

  7. metadata: Remove unused Option from fn dlsym_proc_macros

    @petrochenkov
    petrochenkov committed Oct 3, 2019
    Configuration menu
    Copy the full SHA
    68aadcb View commit details
    Browse the repository at this point in the history