Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Instance::resolve_for_fn_ptr (RFC 2091 #2/N) #65182

Merged
merged 12 commits into from
Oct 13, 2019
Merged

Add Instance::resolve_for_fn_ptr (RFC 2091 #2/N) #65182

merged 12 commits into from
Oct 13, 2019

Commits on Oct 10, 2019

  1. Add InstanceDef::ReifyShim for track_caller functions.

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    012116f View commit details
    Browse the repository at this point in the history

  2. Add Instance::resolve_for_fn_ptr

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    f5f67e7 View commit details
    Browse the repository at this point in the history

  3. Reifying callers of Instance::resolve use resolve_for_fn_ptr.

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    0132738 View commit details
    Browse the repository at this point in the history

  4. Return ReifyShim from Instance::resolve_for_fn_ptr when track_caller … 

    …present.

This ICEs in MIR currently, which I think is to be expected since none of the MIR plumbing is set up. I added a test which confirms that the shim is being used for reifying a track_caller function.
    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    b8414c1 View commit details
    Browse the repository at this point in the history

  5. Clarify comment, dedupe match arms in shim.rs. 

    Also add a missing terminal newline to a test.
    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    8a097f2 View commit details
    Browse the repository at this point in the history

  6. miri calls resolve_for_fn_ptr when reifying.

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    ea3ecf2 View commit details
    Browse the repository at this point in the history

  7. Improve docs for InstanceDef::ReifyShim.

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    1cdd5d0 View commit details
    Browse the repository at this point in the history

  8. Instance::resolve_for_fn_ptr unconditionally resolves first. 

    Per review feedback.
    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    407d1d5 View commit details
    Browse the repository at this point in the history

  9. Clarify shim implementation comment.

    @anp
    anp committed Oct 10, 2019
    Configuration menu
    Copy the full SHA
    2dbc62b View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2019

  1. resolve_for_fn_ptr checks that the instance is an Item before returni… 

    …ng shim.
    @anp
    anp committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    d92cef7 View commit details
    Browse the repository at this point in the history

  2. Clarify comment about purpose of ReifyShim.

    @anp
    anp committed Oct 11, 2019
    Configuration menu
    Copy the full SHA
    2d5ef8f View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2019

  1. Remove the fn pointer #[track_caller] test. 

    The ICE stderr isn't normalizing correctly on some builders.
    @anp
    anp committed Oct 12, 2019
    Configuration menu
    Copy the full SHA
    19f26fa View commit details
    Browse the repository at this point in the history