Bring attention to suggestions when the only difference is capitalization #65398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Centril
reviewed
Oct 14, 2019
davidtwco
approved these changes
Oct 14, 2019
varkor
reviewed
Oct 14, 2019
varkor
reviewed
Oct 14, 2019
estebank
force-pushed
the
capitalization-only
branch
from
641b823
to
6dd718c
Compare
estebank
commented
Oct 14, 2019
|
@bors r=varkor |
|
📌 Commit 8bf6d35 has been approved by |
bors
added
S-waiting-on-bors
tmandry
added a commit
to tmandry/rust
that referenced
this pull request
Oct 15, 2019
Bring attention to suggestions when the only difference is capitalization CC rust-lang#65386.
bors
added a commit
that referenced
this pull request
Oct 15, 2019
Rollup of 10 pull requests Successful merges: - #65170 (rustc_metadata: Privatize private code and remove dead code) - #65260 (Optimize `LexicalResolve::expansion`.) - #65261 (Remove `Option` from `TokenStream`) - #65332 (std::fmt: reorder docs) - #65340 (Several changes to the codegen backend organization) - #65365 (Include const generic arguments in metadata) - #65398 (Bring attention to suggestions when the only difference is capitalization) - #65410 (syntax: add parser recovery for intersection- / and-patterns `p1 @ p2`) - #65415 (Remove an outdated test output file) - #65416 (Minor sync changes) Failed merges: r? @ghost
AnthonyMikh
reviewed
Oct 25, 2019
| let confusable = found.chars().zip(suggested.chars()).filter(|(f, s)| f != s).all(|(f, s)| { | ||
| (ascii_confusables.contains(&f) || ascii_confusables.contains(&s)) | ||
| }); | ||
| confusable && found.to_lowercase() == suggested.to_lowercase() |
There was a problem hiding this comment.
This can avoid an allocation by changing into found.chars().flat_map(char::to_lowercase).eq(suggested.chars().flat_map(char::to_lowercase)). Or it is not worth it?
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC #65386.