Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract rustc_ast_lowering crate from rustc #67574

Merged
merged 4 commits into from
Dec 31, 2019
Merged

Extract rustc_ast_lowering crate from rustc #67574

merged 4 commits into from
Dec 31, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Dec 24, 2019 •
edited
Loading

Working towards #65031.

This PR moves src/librustc/hir/lowering{/, .rs} to its own crate (librustc_ast_lowering) which is very self-contained (only fn lower_crate and trait Resolver are exposed).

r? @Mark-Simulacrum

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 24, 2019
Centril
Centril commented Dec 24, 2019
View reviewed changes
src/librustc/hir/ptr.rs Outdated Show resolved Hide resolved
Centril
Centril commented Dec 24, 2019
View reviewed changes
rustfmt.toml Outdated Show resolved Hide resolved
@cjgillot
Copy link
Contributor

I would have tried doing the other way around: moving the HIR definition along with the lowering, as a librustc dependency.
Why did you prefer this way ?

@Centril
Copy link
Contributor Author

Centril commented Dec 24, 2019

@cjgillot HIR is more entangled into librustc so it will take more work (which I am aiming for in a follow up). But HIR and lowering should, much like the AST and the parser, not be in the same crate.

@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Dec 24, 2019

📌 Commit 81b2c247b0c107b1a861b9adfe2ef4731ae8072c has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 24, 2019
@bors
Copy link
Contributor

bors commented Dec 24, 2019

⌛ Testing commit 81b2c247b0c107b1a861b9adfe2ef4731ae8072c with merge c3db61f9bba900a5fccf9a5e4c261b8e1b515de0...

@Zoxc

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 24, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@Mark-Simulacrum

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@Zoxc

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 25, 2019
@petrochenkov

This comment has been minimized.

Sign in to view
@Centril

This comment has been minimized.

Sign in to view
@petrochenkov
Copy link
Contributor

perhaps rustc_ast_lowering because it transforms AST to HIR

+1

(Also, for some reason I thought the PR was already merged.)

@Centril Centril changed the title Extract rustc_lowering crate from rustc Extract rustc_ast_lowering crate from rustc Dec 31, 2019
@Centril
Copy link
Contributor Author

Centril commented Dec 31, 2019 •
edited
Loading

  • Last HIR-arena PR has landed.
  • I've renamed the crate to rustc_ast_lowering per discussion.
  • Since this is a new crate, I went with rustc_span instead of syntax_pos from the get-go.

@bors r=Mark-Simulacrum

@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 31, 2019
@bors
Copy link
Contributor

bors commented Dec 31, 2019

📌 Commit 70eca99 has been approved by Mark-Simulacrum

Centril added a commit to Centril/rust that referenced this pull request Dec 31, 2019
@Centril
Rollup merge of rust-lang#67574 - Centril:librustc_lowering, r=Mark-S…
3cf2bc0 
…imulacrum

Extract `rustc_ast_lowering` crate from `rustc`

Working towards rust-lang#65031.

This PR moves `src/librustc/hir/lowering{/, .rs}` to its own crate (`librustc_ast_lowering`) which is very self-contained (only `fn lower_crate` and `trait Resolver` are exposed).

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Dec 31, 2019
Merged
bors added a commit that referenced this pull request Dec 31, 2019
@bors
Auto merge of #67764 - Centril:rollup-ycbq3os, r=Centril
119307a 
Rollup of 6 pull requests

Successful merges:

 - #67574 (Extract `rustc_ast_lowering` crate from `rustc`)
 - #67685 (Constify Result)
 - #67702 (Add symbol normalization for proc_macro_server.)
 - #67730 (Cleanup pattern type checking, fix diagnostics bugs (+ improvements))
 - #67744 (parser: reduce diversity in error handling mechanisms)
 - #67748 (Use function attribute "frame-pointer" instead of "no-frame-pointer-elim")

Failed merges:

r? @ghost
@bors bors merged commit 70eca99 into rust-lang:master Dec 31, 2019
@Centril Centril deleted the librustc_lowering branch December 31, 2019 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Centril @cjgillot @Mark-Simulacrum @bors @Zoxc @rust-highfive @petrochenkov