Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all uses of ty::Error delay a span bug #70551

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Conversation

mark-i-m
Copy link
Member

@mark-i-m mark-i-m commented Mar 30, 2020

r? @eddyb

A second attempt at #70245

resolves #70866

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 30, 2020
@mark-i-m

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 6, 2020
@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 7, 2020

Blocked on resolution of #70866

@rustbot modify labels: +S-blocked

@rustbot rustbot added the S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. label Apr 7, 2020
@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@mark-i-m mark-i-m force-pushed the ty-err-2 branch 2 times, most recently from bb29107 to a3502c2 Compare April 9, 2020 04:43
@rust-highfive

This comment has been minimized.

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 9, 2020
De-abuse TyKind::Error in pattern type checking

r? @eddyb

cc rust-lang#70866

In particular, I would appreciate extra scrutiny over the soundness of these changes.

Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.
Centril added a commit to Centril/rust that referenced this pull request Apr 10, 2020
De-abuse TyKind::Error in pattern type checking

r? @eddyb

cc rust-lang#70866

In particular, I would appreciate extra scrutiny over the soundness of these changes.

Also, this will go a bit slowly because I'm going to use my other PR (rust-lang#70551) to check if I missed anything.
@mark-i-m
Copy link
Member Author

Still blocked on resolution of #70866

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@rust-highfive

This comment has been minimized.

@bors

This comment has been minimized.

@varkor
Copy link
Member

varkor commented Jun 15, 2020

r=me after rebasing.

@mark-i-m
Copy link
Member Author

For some reason I'm having a bit of trouble with this rebase... going to squash some commits and try again...

@mark-i-m
Copy link
Member Author

Ok, this should be ready I think. I squashed 4 of the original commits together into
268decb

@mark-i-m
Copy link
Member Author

Cool! CI is passing :)

Co-authored-by: lzutao <taolzu@gmail.com>
@varkor
Copy link
Member

varkor commented Jun 17, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Jun 17, 2020

📌 Commit cfdbbb5 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Jun 18, 2020
Make all uses of ty::Error delay a span bug

r? @eddyb

A second attempt at rust-lang#70245

resolves rust-lang#70866
Manishearth added a commit to Manishearth/rust that referenced this pull request Jun 18, 2020
Make all uses of ty::Error delay a span bug

r? @eddyb

A second attempt at rust-lang#70245

resolves rust-lang#70866
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 19, 2020
…arth

Rollup of 17 pull requests

Successful merges:

 - rust-lang#70551 (Make all uses of ty::Error delay a span bug)
 - rust-lang#71338 (Expand "recursive opaque type" diagnostic)
 - rust-lang#71976 (Improve diagnostics for `let x += 1`)
 - rust-lang#72279 (add raw_ref macros)
 - rust-lang#72628 (Add tests for 'impl Default for [T; N]')
 - rust-lang#72804 (Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position)
 - rust-lang#72814 (remove visit_terminator_kind from MIR visitor)
 - rust-lang#72836 (Complete the std::time documentation to warn about the inconsistencies between OS)
 - rust-lang#72968 (Only highlight doc search results via mouseover if mouse has moved)
 - rust-lang#73034 (Export `#[inline]` fns with extern indicators)
 - rust-lang#73315 (Clean up some weird command strings)
 - rust-lang#73320 (Make new type param suggestion more targetted)
 - rust-lang#73361 (Tweak "non-primitive cast" error)
 - rust-lang#73425 (Mention functions pointers in the documentation)
 - rust-lang#73428 (Fix typo in librustc_ast docs)
 - rust-lang#73447 (Improve document for `Result::as_deref(_mut)` methods)
 - rust-lang#73476 (Added tooltip for should_panic code examples)

Failed merges:

r? @ghost
@bors bors merged commit 9d388d4 into rust-lang:master Jun 19, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 16, 2020
Add `TyCtxtAt::{ty_error, ty_error_with_message}`

~~Only e2d957d was added, the rest comes from rust-lang#70551.~~
I was unsure where to put the implementation for those methods, please tell me if there is a better place for it.

Closes rust-lang#72619, ~~blocked on rust-lang#70551~~.

r? @eddyb cc @mark-i-m, maybe this should be part of rust-lang#70551? If so feel free to cherry-pick or ask me to file a PR against your fork.
Xanewok added a commit to Xanewok/rust-semverver that referenced this pull request Nov 17, 2020
Xanewok added a commit to Xanewok/rust-semverver that referenced this pull request Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't (ab)use TyKind::Error when not planning to emit error