Do not show DefId in diagnostics #71310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit e171cda has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 19, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#71026 (Fix false "never constructed" warnings for `Self::` variant paths) - rust-lang#71310 (Do not show DefId in diagnostics) - rust-lang#71317 (miri-unleash test for llvm_asm) - rust-lang#71324 (Fix some tests failing in `--pass check` mode) Failed merges: r? @ghost
eddyb
reviewed
Apr 27, 2020
| // Cross-crate closure types should only be | ||
| // visible in codegen bug reports, I imagine. | ||
| p!(write("@{:?}", did)); | ||
| p!(write("@{}", self.tcx().def_path_str(did))); |
There was a problem hiding this comment.
You can see above that p!(write("@"), print_def_path(did, substs)); is the right way to do this (used in the local case with span_free_formats).
There was a problem hiding this comment.
Oh, overlooked this comment, sorry! Will address it soonish.
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Oct 26, 2020
Prefer to use `print_def_path` Follow-up of rust-lang#71310 (comment)
81 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71222
r? @estebank cc @eddyb