Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 15 pull requests #73455

Closed
wants to merge 55 commits into from
Closed

Commits on May 20, 2020

  1. Implement partial error recovery for let with BinOpEq

    When parsing `let x: i8 += 1` the compiler interprets `i8` as a trait
    which makes it more complicated to do error recovery. More advanced
    error recovery is not implemented in this commit.
    mibac138 committed May 20, 2020
    Configuration menu
    Copy the full SHA
    d4fe955 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48ff12a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    05d6531 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6ad24ba View commit details
    Browse the repository at this point in the history

Commits on May 21, 2020

  1. Configuration menu
    Copy the full SHA
    98532a3 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2020

  1. Configuration menu
    Copy the full SHA
    1bc4e45 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Configuration menu
    Copy the full SHA
    bbb3321 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2020

  1. add raw_ref macros

    RalfJung committed Jun 12, 2020
    Configuration menu
    Copy the full SHA
    f0d2e78 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2020

  1. Configuration menu
    Copy the full SHA
    724dfba View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2020

  1. Configuration menu
    Copy the full SHA
    d5ea0e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a40156e View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2020

  1. Configuration menu
    Copy the full SHA
    9e51008 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81c9094 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4e90f17 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    921f35f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    e755889 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bc15790 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    539e978 View commit details
    Browse the repository at this point in the history
  8. review comments: wording

    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    31ea589 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    10d9bf1 View commit details
    Browse the repository at this point in the history
  10. Register new eror code

    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    34d8692 View commit details
    Browse the repository at this point in the history
  11. small tweaks

    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    e31367d View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    f7a1f97 View commit details
    Browse the repository at this point in the history
  13. fix rebase

    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    bfe1434 View commit details
    Browse the repository at this point in the history
  14. Update src/librustc_typeck/check/cast.rs

    Co-authored-by: lzutao <taolzu@gmail.com>
    nikomatsakis and tesuji authored Jun 15, 2020
    Configuration menu
    Copy the full SHA
    b5809b0 View commit details
    Browse the repository at this point in the history
  15. Expand "recursive opaque type" diagnostic

    Fix rust-lang#70968, partially address rust-lang#66523.
    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    96f5584 View commit details
    Browse the repository at this point in the history
  16. review comments

    estebank committed Jun 15, 2020
    Configuration menu
    Copy the full SHA
    8f12485 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2020

  1. Adjust error message

    oddg committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    f3dfe80 View commit details
    Browse the repository at this point in the history
  2. add tracking issue

    RalfJung committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    0265e4e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5fbef22 View commit details
    Browse the repository at this point in the history
  4. bless all

    RalfJung committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    991dfe7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    d1265e7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    a19dfb5 View commit details
    Browse the repository at this point in the history
  7. Update ui tests

    GuillaumeGomez committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    bad252c View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    1990f97 View commit details
    Browse the repository at this point in the history
  9. Add initial asm!() support for hexagon

    GPRs only
    androm3da committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    7a9f29d View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Fix typo in librustc_ast docs

    Fixed sentence by removing a word.
    pierwill authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    9f2e8ad View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c9dc73d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    38e921b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3a1207f View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#71338 - estebank:recursive-impl-trait, r=ni…

    …komatsakis
    
    Expand "recursive opaque type" diagnostic
    
    Fix rust-lang#70968, partially address rust-lang#66523.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c0d3f22 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#71420 - RalfJung:specialization-incomplete,…

    … r=matthewjasper
    
    Specialization is unsound
    
    As discussed in rust-lang#31844 (comment), it might be a good idea to warn users of specialization that the feature they are using is unsound.
    
    I also expanded the "incomplete feature" warning to link the user to the tracking issue.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c6b7e04 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#71976 - mibac138:let-recovery, r=estebank

    Improve diagnostics for `let x += 1`
    
    Fixes(?) rust-lang#66736
    
    The code responsible for the `E0404` errors is [here](https://github.com/rust-lang/rust/blob/master/src/librustc_parse/parser/ty.rs#L399-L424) which I don't think can be easily modified to prevent emitting an error in one specific case. Because of this I couldn't get rid of `E0404` and instead added `E0067` along with a help message which will fix the problem.
    
    r? @estebank
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    7dc7390 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#72279 - RalfJung:raw-ref-macros, r=nikomats…

    …akis
    
    add raw_ref macros
    
    In rust-lang#64490, various people were in favor of exposing `&raw` as a macro first before making the actual syntax stable. So this PR (unstably) introduces those macros.
    
    I'll create the tracking issue if we're okay moving forward with this.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    4ffa200 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#72331 - oddg:forbid-cast-of-cenum-implement…

    …ing-drop, r=matthewjasper,nikomatsakis
    
    Report error when casting an C-like enum implementing Drop
    
    Following approach described in rust-lang#35941
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    3a29574 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#72804 - estebank:opaque-missing-lts-in-fn-2…

    …, r=nikomatsakis
    
    Further tweak lifetime errors involving `dyn Trait` and `impl Trait` in return position
    
    * Suggest substituting `'static` lifetime in impl/dyn `Trait + 'static` instead of `Trait + 'static + '_`
    * When `'static` is explicit, also suggest constraining argument with it
    * Reduce verbosity of suggestion message and mention lifetime in label
    * Tweak output for overlapping required/captured spans
    * Give these errors an error code
    
    Follow up to rust-lang#72543.
    
    r? @nikomatsakis
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    d75230e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#72836 - poliorcetics:std-time-os-specificit…

    …ies, r=shepmaster
    
    Complete the std::time documentation to warn about the inconsistencies between OS
    
    Fixes rust-lang#48980.
    
    I put the new documentation in `src/libstd/time.rs` at the module-level because it affects all types, even the one that are not directly system dependents if they are used with affected types, but there may be a better place for it.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    c9bad78 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#72968 - integer32llc:docs-arrow-keys, r=Gui…

    …llaumeGomez
    
    Only highlight doc search results via mouseover if mouse has moved
    
    ## What happens
    
    - Go to https://doc.rust-lang.org/stable/std/index.html
    - Put your mouse cursor somewhere in the middle where search results will appear and then don't move the mouse
    - Press 's' to focus the search box
    - Type a query that brings up enough search results to go under where your mouse cursor is
    - Press the down arrow
    - The search result that is one below where your mouse cursor is will be highlighted.
    
    ## What I expected
    
    When not currently using the mouse, I expect doing a search and then pressing the down arrow to always highlight the first search result immediately below the search box.
    
    ## The fix
    
    This feels a bit hacky to me; I'm open to other solutions. This introduces a global JS var that keeps track of whether the person searching has moved their mouse after doing a search or not, and only uses the mouse position to highlight search results if the person HAS moved the mouse AFTER doing a search.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8d5c764 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#73142 - ehuss:std-benches, r=dtolnay

    Ensure std benchmarks get tested.
    
    This ensures that the std benchmarks don't break in the future. Currently they aren't compiled or tested on CI, so they can easily bitrot.  Testing a benchmark runs it with one iteration. Adding these should only add a few seconds to CI.
    
    Closes rust-lang#54176
    Closes rust-lang#61913
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a37e271 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#73214 - androm3da:hex_inline_asm_00, r=Amanieu

    Add asm!() support for hexagon
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    53cc5af View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    9f204c6 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#73305 - crlf0710:disallow_loading_monsters,…

    … r=petrochenkov
    
    Disallow loading crates with non-ascii identifier name.
    
    This turns off external crate loading with non-ascii identifier names.
    
    cc rust-lang#55467.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    1b32e50 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#73315 - GuillaumeGomez:clean-up-config-strs…

    …, r=kinnison
    
    Clean up some weird command strings
    
    r? @kinnison
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    a4c07cd View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#73428 - pierwill:patch-1, r=jonas-schievink

    Fix typo in librustc_ast docs
    
    Fixed sentence by removing a word.
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    172e3cd View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#73446 - ecstatic-morse:issue-73431, r=pnkfelix

    Make novel structural match violations not a `bug`
    
    Fixes (on master) rust-lang#73431.
    
    Ideally, `CustomEq` would emit a strict subset of the structural match errors that are found by `search_for_structural_match_violation`, since it allows more cases due to value-based reasoning. However, const qualification is more conservative than `search_for_structural_match_violation` around associated constants, since qualification does not try to substitute type parameters.
    
    In the long term, we should probably make const qualification work for generic associated constants, but I don't like extending its capabilities even further.
    
    r? @pnkfelix
    tmandry authored Jun 17, 2020
    Configuration menu
    Copy the full SHA
    db841ab View commit details
    Browse the repository at this point in the history