Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #73948 #74292

Closed
wants to merge 1 commit into from
Closed

Fix #73948 #74292

wants to merge 1 commit into from

Conversation

fmckeogh
Copy link
Member

Closes #73948 by adding a note that meta is a reserved name and suggesting the use of the crate:: prefix to reduce ambiguity.

@rust-highfive
Copy link
Collaborator

r? @matthewjasper

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 13, 2020
@bors

This comment has been minimized.

Sign in to view
@fmckeogh
Copy link
Member Author

Resolved the merge conflicts :)

@matthewjasper
Copy link
Contributor

Ideally the cannot find crate error wouldn't be fatal so that resolve would emit an ambiguity error. Maybe @petrochenkov has some ideas on this.

@fmckeogh
Copy link
Member Author

fmckeogh commented Aug 5, 2020

Rebased

@matthewjasper I'm not quite sure I understand, is that the error instantiated on locator.rs:1056?

@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 21, 2020
@Dylan-DPC-zz
Copy link

r? @petrochenkov

@petrochenkov
Copy link
Contributor

Meta: it's preferable to give human-readable titles to PRs, i.e. "Do something specific with things A and B" rather than "Fix #NNNN".

@petrochenkov
Copy link
Contributor

More radical solution - #75802.

@petrochenkov petrochenkov added S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2020
@fmckeogh
Copy link
Member Author

@petrochenkov Should I close this in favour of #75802 ? :)

@bors
Copy link
Contributor

bors commented Aug 30, 2020

☔ The latest upstream changes (presumably #74862) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov
Copy link
Contributor

Yes, let's close for now.
I'll reopen and ping you if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-blocked Status: Marked as blocked ❌ on something else such as an RFC or other implementation work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

meta not indicated as reserved crate name when shadowing module
7 participants
@fmckeogh @rust-highfive @bors @matthewjasper @Dylan-DPC-zz @petrochenkov @crlf0710