Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #74439

Merged
merged 1 commit into from
Jul 17, 2020
Merged

update Miri #74439

merged 1 commit into from
Jul 17, 2020

Conversation

RalfJung
Copy link
Member

Fixes #74345

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 17, 2020
@RalfJung
Copy link
Member Author

Cc @rust-lang/miri
@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jul 17, 2020

📌 Commit 8a917f9 has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 17, 2020
@bors
Copy link
Contributor

bors commented Jul 17, 2020

⌛ Testing commit 8a917f9 with merge 3014f23...

@bors
Copy link
Contributor

bors commented Jul 17, 2020

☀️ Test successful - checks-actions, checks-azure
Approved by: RalfJung
Pushing 3014f23 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 17, 2020
@bors bors merged commit 3014f23 into rust-lang:master Jul 17, 2020
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #74439!

Tested on commit 3014f23.
Direct link to PR: #74439

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 17, 2020
@rust-highfive
📣 Toolstate changed by rust-lang/rust#74439!
aa8bc2f 
Tested on commit rust-lang/rust@3014f23.
Direct link to PR: <rust-lang/rust#74439>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @eddyb @RalfJung).
@RalfJung RalfJung deleted the miri branch July 20, 2020 12:37
@cuviper cuviper added this to the 1.47.0 milestone May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikomatsakis nikomatsakis

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.47.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#74342
5 participants
@RalfJung @rust-highfive @bors @cuviper @nikomatsakis