Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #76129

Closed
wants to merge 31 commits into from

Commits on Aug 25, 2020

  1. Fix typo in release notes

    camelid committed Aug 25, 2020
    Configuration menu
    Copy the full SHA
    acd3962 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Use intra-doc links for core/src/slice.mod.rs

    - most are using primitive types links, which cannot be used with intra
      links at the moment
    - also `std` cannot be referenced in any link
    Amjad50 committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    91e4aaa View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8e33137 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a04e120 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6aae4a2 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    2d6ab12 View commit details
    Browse the repository at this point in the history
  6. Add missing hyphen

    reference counted pointer -> reference-counted pointer
    camelid authored Aug 28, 2020
    Configuration menu
    Copy the full SHA
    7be129e View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Liballoc vec doc use associated function

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    pickfire and Joshua Nelson authored Aug 29, 2020
    Configuration menu
    Copy the full SHA
    c7e428e View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2020

  1. Configuration menu
    Copy the full SHA
    8a92718 View commit details
    Browse the repository at this point in the history
  2. resolve comments

    nixphix committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    01d95f2 View commit details
    Browse the repository at this point in the history
  3. Fix intra-doc path resolution problem in library/alloc/src/slice.rs

    `alloc::slice` uses `core::slice` functions, documentation are copied
    from there and the links as well without resolution. `crate::ptr...`
    cannot be resolved in `alloc::slice`, but `ptr` itself is imported in
    both `alloc::slice` and `core::slice`, so we used that instead.
    Amjad50 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    300a007 View commit details
    Browse the repository at this point in the history
  4. add i32::MAX link

    nixphix committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    7ea4c28 View commit details
    Browse the repository at this point in the history
  5. revert Some(Item) link

    nixphix committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    523fea4 View commit details
    Browse the repository at this point in the history
  6. Run cfg-stripping on generic parameters before invoking derive macros

    Fixes rust-lang#75930
    
    This changes the tokens seen by a proc-macro. However, ising a `#[cfg]` attribute
    on a generic paramter is unusual, and combining it with a proc-macro
    derive is probably even more unusual. I don't expect this to cause any
    breakage.
    Aaron1011 committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    a97dcfa View commit details
    Browse the repository at this point in the history
  7. Move lexer unit tests to rustc_lexer

    StringReader is an intornal abstraction which at the moment changes a
    lot, so these unit tests cause quite a bit of friction.
    
    Moving them to rustc_lexer and more ingerated-testing style should
    make them much less annoying, hopefully without decreasing their
    usefulness much.
    
    Note that coloncolon tests are removed (it's unclear what those are
    testing).
    
    \r\n tests are removed as well, as we normalize line endings even
    before lexing.
    matklad committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    ccffea5 View commit details
    Browse the repository at this point in the history
  8. Remove unused function

    matklad committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    518cac9 View commit details
    Browse the repository at this point in the history
  9. ty: remove obsolete printer

    This commit removes the obsolete printer and replaces all uses of it
    with `FmtPrinter`. Of the replaced uses, all but one use was in `debug!`
    logging, two cases were notable:
    
    - `MonoItem::to_string` is used in `-Z print-mono-items` and therefore
      affects the output of all codegen-units tests.
    - `DefPathBasedNames` was used in `librustc_codegen_llvm/type_of.rs`
      with `LLVMStructCreateNamed` and that'll now get different values, but
      this should result in no functional change.
    
    Signed-off-by: David Wood <david@davidtw.co>
    davidtwco committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    6ff471b View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    7dfbf59 View commit details
    Browse the repository at this point in the history
  11. Add (non-public) slice::split_at_unchecked() and split_at_mut_uncheck…

    …ed()
    
    These are unsafe variants of the non-unchecked functions and don't do
    any bounds checking.
    
    For the time being these are not public and only a preparation for the
    following commit. Making it public and stabilization can follow later
    and be discussed in rust-lang#76014 .
    sdroege committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    30dc32b View commit details
    Browse the repository at this point in the history
  12. Get rid of bounds check in slice::chunks_exact() and related function…

    …s during construction
    
    LLVM can't figure out in
    
        let rem = self.len() % chunk_size;
        let len = self.len() - rem;
        let (fst, snd) = self.split_at(len);
    
    and
    
        let rem = self.len() % chunk_size;
        let (fst, snd) = self.split_at(rem);
    
    that the index passed to split_at() is smaller than the slice length and
    adds a bounds check plus panic for it.
    
    Apart from removing the overhead of the bounds check this also allows
    LLVM to optimize code around the ChunksExact iterator better.
    sdroege committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    d08996a View commit details
    Browse the repository at this point in the history
  13. Improve documentation of slice::get_unchecked() / split_at_unchecked()

    Thanks to Ivan Tham, who gave the majority of these suggestions during
    their review.
    sdroege committed Aug 30, 2020
    Configuration menu
    Copy the full SHA
    8d3cf92 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#74668 - petrochenkov:noname, r=mark-i-m

    cleanup: Remove duplicate library names from `Cargo.toml`s
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    096b49c View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#75926 - camelid:patch-5, r=jonas-schievink

    Fix typo in release notes
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    74d6b94 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#75932 - Amjad50:intra-doc-core-slice, r=jyn514

    Use intra-doc links for `core/src/slice.mod.rs`
    
    partial help in rust-lang#75080
    
    r? @jyn514
    
    - most are using primitive types links, which cannot be used with intra links at the moment
    - also `std` cannot be referenced in any link, `std::ptr::NonNull` and `std::slice` could not be referenced
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    213116f View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#75936 - sdroege:chunks-exact-construction-b…

    …ounds-check, r=nagisa
    
    Get rid of bounds check in slice::chunks_exact() and related function…
    
    …s during construction
    
    LLVM can't figure out in
    
        let rem = self.len() % chunk_size;
        let len = self.len() - rem;
        let (fst, snd) = self.split_at(len);
    
    and
    
        let rem = self.len() % chunk_size;
        let (fst, snd) = self.split_at(rem);
    
    that the index passed to split_at() is smaller than the slice length and
    adds a bounds check plus panic for it.
    
    Apart from removing the overhead of the bounds check this also allows
    LLVM to optimize code around the ChunksExact iterator better.
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    7919f05 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#75969 - nixphix:docs/mod, r=jyn514

    Switch to intra-doc links in core/src/{convert,iter}/mod.rs
    
    Partial fix for rust-lang#75080
    
    @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc
    
    r? @jyn514
    
    couldn't fix these
    
    ```rust
         ../../std/string/struct.String.html
         ../../std/primitive.never.html
         ../../std/sync/mpsc/struct.TryIter.html
    ```
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    e1276a3 View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#76010 - Aaron1011:fix/cfg-generic-param, r=…

    …petrochenkov
    
    Run cfg-stripping on generic parameters before invoking derive macros
    
    Fixes rust-lang#75930
    
    This changes the tokens seen by a proc-macro. However, ising a `#[cfg]` attribute
    on a generic paramter is unusual, and combining it with a proc-macro
    derive is probably even more unusual. I don't expect this to cause any
    breakage.
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    de5646d View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    54fd272 View commit details
    Browse the repository at this point in the history
  21. Rollup merge of rust-lang#76027 - davidtwco:issue-61139-remove-obsole…

    …te-pretty-printer, r=eddyb
    
    ty: remove obsolete pretty printer
    
    Fixes rust-lang#61139.
    
    This PR removes the obsolete printer and replaces all uses of it with `FmtPrinter`. Of the replaced uses, all but one use was in `debug!` logging, two cases were notable:
    
    - `MonoItem::to_string` is used in `-Z print-mono-items` and therefore affects the output of all codegen-units tests (which have been updated).
    - `DefPathBasedNames` was used in `librustc_codegen_llvm/type_of.rs` with `LLVMStructCreateNamed` and that'll now get different values, but nothing will break as a result of this.
    
    cc @eddyb (whom I've discussed this with)
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    10fb8d4 View commit details
    Browse the repository at this point in the history
  22. Rollup merge of rust-lang#76033 - camelid:patch-7, r=Dylan-DPC

    Add missing hyphen
    
    reference counted pointer -> reference-counted pointer
    
    @rustbot modify labels: T-doc
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    264356f View commit details
    Browse the repository at this point in the history
  23. Rollup merge of rust-lang#76050 - matklad:pos, r=petrochenkov

    Remove unused function
    Dylan-DPC authored Aug 30, 2020
    Configuration menu
    Copy the full SHA
    46d66d9 View commit details
    Browse the repository at this point in the history