Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Various str tests in library #76369

Merged

Conversation

ayushmishra2005
Copy link
Contributor

Moved various string ui tests in library as a part of #76268

r? @matklad

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2020
@jyn514 jyn514 added A-testsuite Area: The testsuite used to check the correctness of rustc T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Sep 5, 2020
@jyn514
Copy link
Member

jyn514 commented Sep 5, 2020

This would belong better in string.rs I think, e.g.

fn test_from_str() {

@jyn514
Copy link
Member

jyn514 commented Sep 5, 2020

Actually it looks like this is testing string literals themselves, not .to_string()? Then I'm not sure it should be moved ... I'll wait to hear what matklad says.

@ayushmishra2005
Copy link
Contributor Author

Actually it looks like this is testing string literals themselves, not .to_string()? Then I'm not sure it should be moved ... I'll wait to hear what matklad says.

@jyn514 Shall I move in string.rs or wait for @matklad to provide any feedback?

@jyn514
Copy link
Member

jyn514 commented Sep 6, 2020

Wait for matklad's opinion I think, this was just a drive-by review :P

@ayushmishra2005
Copy link
Contributor Author

Wait for matklad's opinion I think, this was just a drive-by review :P

Hi @matklad Please provide your feedback for this PR.

@jyn514
Copy link
Member

jyn514 commented Sep 15, 2020

@bors r+ rollup

This looks fine, if there are issues they can be fixed later.

@bors
Copy link
Contributor

bors commented Sep 15, 2020

📌 Commit 7d834c8 has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 15, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 16, 2020
…sts_library, r=jyn514

Move Various str tests in library

Moved various string ui  tests in library  as a part of rust-lang#76268

r? @matklad
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 16, 2020
Rollup of 10 pull requests

Successful merges:

 - rust-lang#76056 (Add more info for Vec Drain doc)
 - rust-lang#76062 (Vec slice example fix style and show type elision)
 - rust-lang#76262 (Use inline(never) instead of cold)
 - rust-lang#76335 (Make all methods of `Duration` unstably const)
 - rust-lang#76366 (Add Arith Tests in Library)
 - rust-lang#76369 (Move Various str tests in library)
 - rust-lang#76534 (Add doc comments for From impls)
 - rust-lang#76622 (Update bootstrap readme)
 - rust-lang#76641 (Some cleanup changes and commenting)
 - rust-lang#76662 (Fix liballoc test suite for Miri)

Failed merges:

r? `@ghost`
@bors bors merged commit 3a4de42 into rust-lang:master Sep 16, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants