Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liballoc bench use imported path Bencher #76981

Merged
merged 1 commit into from
Sep 21, 2020
Merged

liballoc bench use imported path Bencher #76981

merged 1 commit into from
Sep 21, 2020

Conversation

pickfire
Copy link
Contributor

test is already in scope, no need to use the full path

@pickfire
liballoc bench use imported path Bencher
d99bb9d 
test is already in scope, no need to use the full path
@rust-highfive
Copy link
Collaborator

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 20, 2020
@pickfire
Copy link
Contributor Author

pickfire commented Sep 20, 2020 •
edited
Loading

@pickfire change mem::take to mem::replace and rand::RngCore import and LEN = 16384 (and pos) and once instead of [0].iter() after this.

@rustbot modify labels: +C-cleanup +A-testsuite

@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 20, 2020

📌 Commit d99bb9d has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
@jyn514 jyn514 added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testsuite Area: The testsuite used to check the correctness of rustc labels Sep 20, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 21, 2020
@RalfJung
Rollup merge of rust-lang#76981 - pickfire:patch-5, r=Mark-Simulacrum
5f47246 
liballoc bench use imported path Bencher

test is already in scope, no need to use the full path
@RalfJung RalfJung mentioned this pull request Sep 21, 2020
Closed
@RalfJung RalfJung mentioned this pull request Sep 21, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 21, 2020
@bors
Auto merge of rust-lang#77013 - RalfJung:rollup-84ut0xq, r=RalfJung
4eff9b0 
Rollup of 10 pull requests

Successful merges:

 - rust-lang#76439 (Add error explanation for E0755)
 - rust-lang#76521 (Fix segfault if pthread_getattr_np fails)
 - rust-lang#76835 (make replace_prefix only take &str as arguments )
 - rust-lang#76967 (Revert adding Atomic::from_mut.)
 - rust-lang#76977 (Add a regression test for copy propagation miscompilation)
 - rust-lang#76981 (liballoc bench use imported path Bencher)
 - rust-lang#76983 (BTreeMap: extra testing & fixed comments)
 - rust-lang#76996 (Fix typo in rustc_lexer docs)
 - rust-lang#77009 (Dogfood total_cmp in the test crate)
 - rust-lang#77012 (update Miri for another bugfix)

Failed merges:

 - rust-lang#76489 (Add explanation for E0756)

r? `@ghost`
@bors bors merged commit 4b362bb into rust-lang:master Sep 21, 2020
@rustbot rustbot added this to the 1.48.0 milestone Sep 21, 2020
@pickfire pickfire deleted the patch-5 branch September 22, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cramertj cramertj

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.48.0
Development

Successfully merging this pull request may close these issues.
7 participants
@pickfire @rust-highfive @Mark-Simulacrum @bors @cramertj @jyn514 @rustbot