-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #76987
Rollup of 14 pull requests #76987
Commits on Aug 10, 2020
-
Configuration menu - View commit details
-
Copy full SHA for b1375cd - Browse repository at this point
Copy the full SHA b1375cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3a22b21 - Browse repository at this point
Copy the full SHA 3a22b21View commit details
Commits on Aug 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for ee289d2 - Browse repository at this point
Copy the full SHA ee289d2View commit details
Commits on Sep 9, 2020
-
Fix segfault if pthread_getattr_np fails
glibc destroys[1] the passed pthread_attr_t if pthread_getattr_np() fails. Destroying it again leads to a segfault. Fix it by only destroying it on success for glibc. [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getattr_np.c;h=ce437205e41dc05653e435f6188768cccdd91c99;hb=HEAD#l205
Configuration menu - View commit details
-
Copy full SHA for a06edda - Browse repository at this point
Copy the full SHA a06eddaView commit details -
Only call pthread_attr_destroy() after getattr_np() succeeds on all l…
…ibcs The calling convention of pthread_getattr_np() is to initialize the pthread_attr_t, so _destroy() is only necessary on success (and _init() isn't necessary beforehand). On the other hand, FreeBSD wants the attr_t to be initialized before pthread_attr_get_np(), and therefore it should always be destroyed afterwards.
Configuration menu - View commit details
-
Copy full SHA for a684153 - Browse repository at this point
Copy the full SHA a684153View commit details
Commits on Sep 12, 2020
-
Make some methods of
Pin
unstable constMake the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654
Configuration menu - View commit details
-
Copy full SHA for 8f27e3c - Browse repository at this point
Copy the full SHA 8f27e3cView commit details
Commits on Sep 13, 2020
-
Only insert StorageDeads if we actually removed one. Fixes an issue where we added StorageDead to a place with no StorageLive
Configuration menu - View commit details
-
Copy full SHA for e5447a2 - Browse repository at this point
Copy the full SHA e5447a2View commit details -
MIR pass to remove unneeded drops on types not needing drop
This is heavily dependent on MIR inlining running to actually see the drop statement
Configuration menu - View commit details
-
Copy full SHA for 9c5d0c1 - Browse repository at this point
Copy the full SHA 9c5d0c1View commit details
Commits on Sep 14, 2020
-
Co-authored-by: Andreas Jonson <andjo403@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 9d47ecf - Browse repository at this point
Copy the full SHA 9d47ecfView commit details
Commits on Sep 18, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 4675a31 - Browse repository at this point
Copy the full SHA 4675a31View commit details -
Configuration menu - View commit details
-
Copy full SHA for bffd211 - Browse repository at this point
Copy the full SHA bffd211View commit details -
Configuration menu - View commit details
-
Copy full SHA for 982ec0d - Browse repository at this point
Copy the full SHA 982ec0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b534d9f - Browse repository at this point
Copy the full SHA b534d9fView commit details -
Make some methods of
Pin<&mut T>
unstable constMake the following methods unstable const under the `const_pin` feature: - `into_ref` - `get_mut` - `get_unchecked_mut`
Configuration menu - View commit details
-
Copy full SHA for e3c6e46 - Browse repository at this point
Copy the full SHA e3c6e46View commit details
Commits on Sep 19, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 673935f - Browse repository at this point
Copy the full SHA 673935fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 30dd6cf - Browse repository at this point
Copy the full SHA 30dd6cfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 804f673 - Browse repository at this point
Copy the full SHA 804f673View commit details -
Configuration menu - View commit details
-
Copy full SHA for 924cd13 - Browse repository at this point
Copy the full SHA 924cd13View commit details -
Configuration menu - View commit details
-
Copy full SHA for af1e363 - Browse repository at this point
Copy the full SHA af1e363View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca15e9d - Browse repository at this point
Copy the full SHA ca15e9dView commit details
Commits on Sep 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 2a00dda - Browse repository at this point
Copy the full SHA 2a00ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6734230 - Browse repository at this point
Copy the full SHA 6734230View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b3419 - Browse repository at this point
Copy the full SHA 65b3419View commit details -
Configuration menu - View commit details
-
Copy full SHA for cebbd9f - Browse repository at this point
Copy the full SHA cebbd9fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43193dc - Browse repository at this point
Copy the full SHA 43193dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bc0e55 - Browse repository at this point
Copy the full SHA 4bc0e55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e56b52 - Browse repository at this point
Copy the full SHA 0e56b52View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b85a6 - Browse repository at this point
Copy the full SHA 08b85a6View commit details -
Add non-
unsafe
.get_mut()
forUnsafeCell
Update the tracking issue number Updated the documentation for `UnsafeCell` Address review comments Address more review comments + minor changes
Configuration menu - View commit details
-
Copy full SHA for 8169989 - Browse repository at this point
Copy the full SHA 8169989View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5886c38 - Browse repository at this point
Copy the full SHA 5886c38View commit details -
Configuration menu - View commit details
-
Copy full SHA for aaddcdb - Browse repository at this point
Copy the full SHA aaddcdbView commit details -
Add sample defaults for config.toml
- Allow including defaults in `src/bootstrap/defaults` using `profile = "..."` - Add default config files - Combine config files using the merge dependency. - Add comments to default config files - Add a README asking to open an issue if the defaults are bad - Give a loud error if trying to merge `.target`, since it's not currently supported - Use an exhaustive match - Use `<none>` in config.toml.example to avoid confusion - Fix bugs in `Merge` derives Previously, it would completely ignore the profile defaults if there were any settings in `config.toml`. I sent an email to the `merge` maintainer asking them to make the behavior in this commit the default. This introduces a new dependency on `merge` that hasn't yet been vetted. I want to improve the output when `include = "x"` isn't found: ``` thread 'main' panicked at 'fs::read_to_string(&file) failed with No such file or directory (os error 2) ("configuration file did not exist")', src/bootstrap/config.rs:522:28 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failed to run: /home/joshua/rustc/build/bootstrap/debug/bootstrap test tidy Build completed unsuccessfully in 0:00:00 ``` However that seems like it could be fixed in a follow-up.
Configuration menu - View commit details
-
Copy full SHA for c9c8fb8 - Browse repository at this point
Copy the full SHA c9c8fb8View commit details -
- Add a changelog and instructions for updating it - Use `changelog-seen` in `config.toml` and `VERSION` in bootstrap to determine whether the changelog has been read - Nag people if they haven't read the x.py changelog + Print message twice to make sure it's seen - Give different error messages depending on whether the version needs to be updated or added
Configuration menu - View commit details
-
Copy full SHA for 8e10905 - Browse repository at this point
Copy the full SHA 8e10905View commit details
Commits on Sep 21, 2020
-
Rollup merge of rust-lang#74225 - poliorcetics:std-thread-unsafe-op-i…
…n-unsafe-fn, r=joshtriplett Std/thread: deny unsafe op in unsafe fn Partial fix of rust-lang#73904. This encloses `unsafe` operations in `unsafe fn` in `libstd/thread`. @rustbot modify labels: F-unsafe-block-in-unsafe-fn
Configuration menu - View commit details
-
Copy full SHA for 4cb73e3 - Browse repository at this point
Copy the full SHA 4cb73e3View commit details -
Rollup merge of rust-lang#75974 - SkiFire13:peekmut-opt-sift, r=Lukas…
…Kalbertodt Avoid useless sift_down when std::collections::binary_heap::PeekMut is never mutably dereferenced If `deref_mut` is never called then it's not possible for the element to be mutated without internal mutability, meaning there's no need to call `sift_down`. This could be a little improvement in cases where you want to mutate the biggest element of the heap only if it satisfies a certain predicate that needs only read access to the element.
Configuration menu - View commit details
-
Copy full SHA for ac0e987 - Browse repository at this point
Copy the full SHA ac0e987View commit details -
Rollup merge of rust-lang#76521 - tavianator:fix-pthread-getattr-dest…
…roy, r=Amanieu Fix segfault if pthread_getattr_np fails glibc [destroys][1] the passed pthread_attr_t if pthread_getattr_np() fails. Destroying it again leads to a segfault. Fix it by only destroying it on success for glibc. [1]: https://sourceware.org/git/?p=glibc.git;a=blob;f=nptl/pthread_getattr_np.c;h=ce437205e41dc05653e435f6188768cccdd91c99;hb=HEAD#l205
Configuration menu - View commit details
-
Copy full SHA for 6dd9926 - Browse repository at this point
Copy the full SHA 6dd9926View commit details -
Rollup merge of rust-lang#76581 - lcnr:bound-too-generic, r=eddyb
do not ICE on bound variables, return `TooGeneric` instead fixes rust-lang#73260, fixes rust-lang#74634, fixes rust-lang#76595 r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 55e26f4 - Browse repository at this point
Copy the full SHA 55e26f4View commit details -
Rollup merge of rust-lang#76626 - jyn514:x.py-changelog, r=Mark-Simul…
…acrum Add a changelog for x.py and nag contributors until they read it Add a changelog for x.py - Add a changelog and instructions for updating it - Use `changelog-seen` in `config.toml` and `VERSION` in bootstrap to determine whether the changelog has been read. There's no way to tie reading the changelog to updating the version, so unfortunately they still have to update `config.toml` manually. Actually reading the changelog is optional, anyone can set `changelog-seen = N` without reading (although it's not recommended). - Nag people if they haven't read the x.py changelog + Print message twice to make sure it's seen - Give different error messages depending on whether the version needs to be updated or added Closes rust-lang#76617 r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for f20fa17 - Browse repository at this point
Copy the full SHA f20fa17View commit details -
Rollup merge of rust-lang#76628 - jyn514:default-config-files, r=Mark…
…-Simulacrum Add sample defaults for config.toml - Allow including defaults in `src/bootstrap/defaults` using `profile = "..."`. - Add default config files, with a README noting they're experimental and asking you to open an issue if you run into trouble. The config files have comments explaining why the defaults are set. - Combine config files using the `merge` dependency. This introduces a new dependency on `merge` that hasn't yet been vetted. I want to improve the output when `include = "x"` isn't found: ``` thread 'main' panicked at 'fs::read_to_string(&file) failed with No such file or directory (os error 2) ("configuration file did not exist")', src/bootstrap/config.rs:522:28 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace failed to run: /home/joshua/rustc/build/bootstrap/debug/bootstrap test tidy Build completed unsuccessfully in 0:00:00 ``` However that seems like it could be fixed in a follow-up. Closes rust-lang#76619
Configuration menu - View commit details
-
Copy full SHA for ee3743d - Browse repository at this point
Copy the full SHA ee3743dView commit details -
Rollup merge of rust-lang#76655 - CDirkx:const-pin, r=ecstatic-morse
Make some methods of `Pin` unstable const Make the following methods unstable const under the `const_pin` feature: - `new` - `new_unchecked` - `into_inner` - `into_inner_unchecked` - `get_ref` - `into_ref` - `get_mut` - `get_unchecked_mut` Of these, `into_inner` and `into_inner_unchecked` require the unstable `const_precise_live_drops`. Also adds tests for these methods in a const context. Tracking issue: rust-lang#76654 r? @ecstatic-morse
Configuration menu - View commit details
-
Copy full SHA for 71cdf25 - Browse repository at this point
Copy the full SHA 71cdf25View commit details -
Rollup merge of rust-lang#76659 - simonvandel:76432, r=oli-obk
SimplifyComparisonIntegral: fix miscompilation Fixes rust-lang#76432 Only insert StorageDeads if we actually removed one. Fixes an issue where we added StorageDead to a place with no StorageLive r? @oli-obk
Configuration menu - View commit details
-
Copy full SHA for 5f4afbb - Browse repository at this point
Copy the full SHA 5f4afbbView commit details -
Rollup merge of rust-lang#76673 - simonvandel:remove-unneeded-drops, …
…r=oli-obk MIR pass to remove unneeded drops on types not needing drop This is heavily dependent on MIR inlining running to actually see the drop statement. Do we want to special case replacing a call to std::mem::drop with a goto aswell?
Configuration menu - View commit details
-
Copy full SHA for 62ddc9b - Browse repository at this point
Copy the full SHA 62ddc9bView commit details -
Rollup merge of rust-lang#76867 - poliorcetics:intra-doc-core-iter, r…
…=jyn514 Use intra-doc links in core/src/iter when possible Helps with rust-lang#75080. I also updated lots of links to use `fn()` instead of `fn` when possible. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
Configuration menu - View commit details
-
Copy full SHA for b7dc6d5 - Browse repository at this point
Copy the full SHA b7dc6d5View commit details -
Rollup merge of rust-lang#76868 - poliorcetics:intra-doc-std-sync, r=…
…jyn514 Finish moving to intra doc links for std::sync Helps with rust-lang#75080. @rustbot modify labels: T-doc A-intra-doc-links r? @jyn514
Configuration menu - View commit details
-
Copy full SHA for 72a86bf - Browse repository at this point
Copy the full SHA 72a86bfView commit details -
Rollup merge of rust-lang#76936 - danielhenrymantilla:unsafecell_get_…
…mut, r=RalfJung Add non-`unsafe` `.get_mut()` for `Unsafecell` - Tracking issue: rust-lang#76943 As discussed in: https://internals.rust-lang.org/t/add-non-unsafe-get-mut-for-unsafecell/12407 - ### [Rendered documentation](https://modest-dubinsky-1f9f47.netlify.app/core/cell/struct.unsafecell) This PR tries to move the sound `&mut UnsafeCell<T> -> &mut T` projection that all the "downstream" constructions were already relying on, up to the root abstraction, where it rightfully belongs, and officially blessing it. - this **helps reduce the amount of `unsafe` snippets out there** (_c.f._, the second commit of this PR: rust-lang@09503fd) The fact that this getter is now expose for `UnsafeCell<T>` itself, will also help convey the idea that **`UnsafeCell` is not magical _w.r.t._ `&mut` accesses**, contrary to what some people incorrectly think. - Even the standard library itself at some point had such a confusion, _c.f._ this comment where there is a mention of multi-threaded (and thus _shared_) access despite dealing with exclusive references over unique ownership: https://github.com/rust-lang/rust/blob/59fb88d061544a035f3043b47594b34789204cee/library/core/src/cell.rs#L498-L499 r? @RalfJung
Configuration menu - View commit details
-
Copy full SHA for 4289998 - Browse repository at this point
Copy the full SHA 4289998View commit details -
Rollup merge of rust-lang#76958 - est31:ns, r=oli-obk
Replace manual as_nanos and as_secs_f64 reimplementations
Configuration menu - View commit details
-
Copy full SHA for bfb1d0e - Browse repository at this point
Copy the full SHA bfb1d0eView commit details -
Rollup merge of rust-lang#76959 - est31:write, r=oli-obk
Replace write_fmt with write! Latter is simpler
Configuration menu - View commit details
-
Copy full SHA for 4098d2a - Browse repository at this point
Copy the full SHA 4098d2aView commit details