Check for missing const-stability attributes in rustc_passes
#77203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
ecstatic-morse
force-pushed
the
const-stability-attr-checks
branch
from
0ca3db8
to
490bcbd
Compare
This used to happen as a side-effect of `is_min_const_fn`, which was subtle.
This should be caught by the new check in `rustc_passes`. At some point, this function will be removed entirely.
ecstatic-morse
force-pushed
the
const-stability-attr-checks
branch
from
490bcbd
to
6ce178f
Compare
oli-obk
reviewed
Sep 26, 2020
| @@ -50,7 +50,7 @@ pub fn is_min_const_fn(tcx: TyCtxt<'_>, def_id: DefId) -> bool { | |||
| None => { | |||
| if let Some(stab) = tcx.lookup_stability(def_id) { | |||
| if stab.level.is_stable() { | |||
| tcx.sess.span_err( | |||
There was a problem hiding this comment.
can we just span_bug! here now, or is it still reachable even if the stability error was reported?
There was a problem hiding this comment.
This function is called in check_unsafety, which runs before MissingStabilityAnnotations.
|
r? @oli-obk |
|
@bors r+ |
|
📌 Commit 6ce178f has been approved by |
bors
added
S-waiting-on-bors
This was referenced Sep 27, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 27, 2020
…as-schievink Rollup of 7 pull requests Successful merges: - rust-lang#76839 (Add asm! support for MIPS) - rust-lang#77203 (Check for missing const-stability attributes in `rustc_passes`) - rust-lang#77249 (Separate `private_intra_doc_links` and `broken_intra_doc_links` into separate lints) - rust-lang#77252 (reduce overlong line) - rust-lang#77256 (Fix typo in ExpnData documentation) - rust-lang#77262 (Remove duplicate comment) - rust-lang#77263 (Clean up trivial if let) Failed merges: r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this happens as a side effect of
is_min_const_fn, which is non-obvious. Also adds a test for this case, since we didn't seem to have one before.