Rollup of 14 pull requests #77350
Closed
Rollup of 14 pull requests #77350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes rust-lang/wg-cargo-std-aware#53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>
Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`.
…k() in std::sys::unix::process::Command::spawn() `assert!` panics on failure, which is not signal-safe.
mem::ManuallyDrop::new -> ManuallyDrop::new
StableHasher is supposed to ensure platform independence by converting integers to little-endian and extending isize and usize to 64 bits as necessary, but in fact, much of that work is already handled by SipHasher128. In particular, SipHasher128 implements short_write in an endian-independent way, yet both StableHasher and SipHasher128 additionally attempt to achieve endian-independence by byte swapping on BE hardware before invoking short writes. This double swap has no effect, so let's remove it. Because short_write is endian-independent, SipHasher128 is already handling part of the platform-independence, and it would be somewhat difficult to make it *not* handle that part with the current implementation. As splitting platform-independence responsibilities between StableHasher and SipHasher128 would be confusing, let's make SipHasher128 handle all of it. Finally, update some incorrect comments and increase test coverage. Unit tests pass on both LE and BE systems.
BTreeMap: keep an eye out on the size of the main components r? @Mark-Simulacrum
Ensure that all LLVM components requested by tests are available on CI Addresses #75064 (comment) I used an environment variable because passing a command line option all the way from CI to compiletest would be just too much hassle for this task. I added a new variable, but any of the already existing ones defined by CI could be used instead. r? @Mark-Simulacrum
library: Forward compiler-builtins "mem" feature This fixes rust-lang/wg-cargo-std-aware#53 Now users will be able to do: ``` cargo build -Zbuild-std=core -Zbuild-std-features=compiler-builtins-mem ``` and correctly get the Rust implemenations for `memcpy` and friends. Signed-off-by: Joe Richey <joerichey@google.com>
Don't warn if the config file is somewhere other than `config.toml` Previously, `config.config` was always hardcoded as `"config.toml"`. I thought that it was being overridden with the actual value later, but it turns out `flags.config` was being completely discarded. This keeps `config.config` in sync with `flags.config`. Fixes #77293 r? @Mark-Simulacrum cc @davidtwco
move candidate_from_obligation_no_cache It's only called from `candidate_from_obligation` which is already in this file.
SipHasher128: fix platform-independence confusion StableHasher is supposed to ensure platform independence by converting integers to little-endian and extending isize and usize to 64 bits as necessary, but in fact, much of that work is already handled by SipHasher128. In particular, SipHasher128 implements short_write in an endian-independent way, yet both StableHasher and SipHasher128 additionally attempt to achieve endian-independence by byte swapping on BE hardware before invoking short writes. This double swap has no effect, so let's remove it. Because short_write is endian-independent, SipHasher128 is already handling part of the platform-independence, and it would be somewhat difficult to make it *not* handle that part with the current implementation. As splitting platform-independence responsibilities between StableHasher and SipHasher128 would be confusing, let's make SipHasher128 handle all of it. Finally, update some incorrect comments and increase test coverage. Unit tests pass on both LE and BE systems.
Add unstable book docs for `-Zunsound-mir-opts` The `-Zunsound-mir-opts` flag was added in #76899.
…rochenkov Don't fire `const_item_mutation` lint on writes through a pointer Fixes #77321
Use `rtassert!` instead of `assert!` from the child process after fork() in std::sys::unix::process::Command::spawn() As discussed in #73894, `assert!` panics on failure, which is not signal-safe, and `rtassert!` is a suitable replacement. Fixes #73894. r? @Amanieu @cuviper @joshtriplett
Add test for async/await combined with const-generics. Fixes #74906.
Fix typo in alloc vec comment cc @the8472
Alloc vec use imported path mem::ManuallyDrop::new -> ManuallyDrop::new cc @the8472
Update books ## rust-by-example 5 commits in 19f0a0372af497b34369cf182d9d16156cab2969..7d3ff1c12db08a847a57a054be4a7951ce532d2d 2020-08-26 09:38:48 -0300 to 2020-09-28 15:54:25 -0300 - Prevent duplicated error information in "wrapping errors" example (rust-lang/rust-by-example#1375) - Avoid lifetime annotation in struct example (rust-lang/rust-by-example#1378) - Clone.md comment and variable name change (rust-lang/rust-by-example#1379) - Replace panic example with a simpler version (rust-lang/rust-by-example#1380) - Prefer `const` over `static` (rust-lang/rust-by-example#1381) ## embedded-book 1 commits in 0cd2ca116274b915924c3a7e07c1e046b6f19b77..dd310616308e01f6cf227f46347b744aa56b77d9 2020-08-19 10:33:15 +0000 to 2020-09-26 08:54:08 +0000 - Add instructions for ARM v8 instruction sets (rust-embedded/book#265)
Update cargo 8 commits in 05c611ae3c4255b7a2bcf4fcfa65b20286a07839..75615f8e69f748d7ef0df7bc0b064a9b1f5c78b2 2020-09-23 23:10:38 +0000 to 2020-09-29 18:42:19 +0000 - Correct mistake about supporting sub-makes and document CARGO_MAKEFLAGS (rust-lang/cargo#8741) - Properly set for_host for proc-macro tests. (rust-lang/cargo#8742) - Add Zsh completion for target triples (rust-lang/cargo#8740) - Reinitialize index on "Object not found" error. (rust-lang/cargo#8735) - Normalize raw string indentation. (rust-lang/cargo#8739) - Update links to rustup docs. (rust-lang/cargo#8738) - Add contributor guide. (rust-lang/cargo#8715) - Fix minor error in `cargo update` docs. (rust-lang/cargo#8737)
|
📌 Commit 9a978cd has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 9a978cd with merge 7fd9f732b4aae186e6258cccaac268d179729fb6... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
I updated #77319 with a fix that hopefully addresses the CI test failure. Edit: I need to update that PR some more, so it probably shouldn't be merged as it is now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
config.toml#77298 (Don't warn if the config file is somewhere other thanconfig.toml)-Zunsound-mir-opts#77322 (Add unstable book docs for-Zunsound-mir-opts)const_item_mutationlint on writes through a pointer #77324 (Don't fireconst_item_mutationlint on writes through a pointer)rtassert!instead ofassert!from the child process after fork() in std::sys::unix::process::Command::spawn() #77328 (Usertassert!instead ofassert!from the child process after fork() in std::sys::unix::process::Command::spawn())Failed merges:
r? @ghost